MIME-Version: 1.0
In-Reply-To: <tip-b7b7c7821d932ba18ef6c8eafc8536066b4c2ef4@git.kernel.org>
References: <1437407346-31186-1-git-send-email-kan.liang@intel.com> <tip-b7b7c7821d932ba18ef6c8eafc8536066b4c2ef4@git.kernel.org>
From: Andy Lutomirski <luto@amacapital.net>
Date: Tue, 4 Aug 2015 07:50:21 -0700
Message-ID: <CALCETrXffVT=KQpURGLEAXH5x6KxXhYuicGgk3hmF8-QGT81jw@mail.gmail.com>
Subject: Re: [tip:perf/core] perf/x86: Add an MSR PMU driver
To: Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Andrew Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        "Liang, Kan" <kan.liang@intel.com>, Ingo Molnar <mingo@kernel.org>
Cc: "linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1899
Lines: 59

On Tue, Aug 4, 2015 at 2:01 AM, tip-bot for Andy Lutomirski
<tipbot@zytor.com> wrote:
> Commit-ID:  b7b7c7821d932ba18ef6c8eafc8536066b4c2ef4
> Gitweb:     http://git.kernel.org/tip/b7b7c7821d932ba18ef6c8eafc8536066b4c2ef4
> Author:     Andy Lutomirski <luto@kernel.org>

I think I'm slightly late to the party reviewing what appears to be my
own code :)

> --- /dev/null
> +++ b/arch/x86/kernel/cpu/perf_event_msr.c
> @@ -0,0 +1,242 @@
> +#include <linux/perf_event.h>
> +
> +enum perf_msr_id {
> +       PERF_MSR_TSC                    = 0,
> +       PERF_MSR_APERF                  = 1,
> +       PERF_MSR_MPERF                  = 2,
> +       PERF_MSR_PPERF                  = 3,
> +       PERF_MSR_SMI                    = 4,
> +
> +       PERF_MSR_EVENT_MAX,
> +};
> +
> +struct perf_msr {
> +       int     id;
> +       u64     msr;
> +};
> +
> +static struct perf_msr msr[] = {
> +       { PERF_MSR_TSC, 0 },
> +       { PERF_MSR_APERF, MSR_IA32_APERF },
> +       { PERF_MSR_MPERF, MSR_IA32_MPERF },
> +       { PERF_MSR_PPERF, MSR_PPERF },
> +       { PERF_MSR_SMI, MSR_SMI_COUNT },
> +};

I think this could be easier to work with if it were [PERF_MSR_TSC] =
{...}, etc.  No big deal, though, until the list gets long.  However,
it might make fixing the apparent issue below easier...

> +static int msr_event_init(struct perf_event *event)
> +{
> +       u64 cfg = event->attr.config;

...

> +       event->hw.event_base = msr[cfg].msr;

Shouldn't this verify that the fancy enumeration code actually
believes that msr[cfg] exists on this system?  Otherwise we might have
a very short wait until the perf fuzzer oopses this thing :)

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/