Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934813AbbHDPGp (ORCPT ); Tue, 4 Aug 2015 11:06:45 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47721 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934797AbbHDPGl (ORCPT ); Tue, 4 Aug 2015 11:06:41 -0400 Message-ID: <55C0D4FA.9080305@codeaurora.org> Date: Tue, 04 Aug 2015 20:36:34 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Boyd CC: devicetree@vger.kernel.org, dehrenberg@google.com, linux-arm-msm@vger.kernel.org, cernekee@gmail.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, agross@codeaurora.org, computersforpeace@gmail.com Subject: Re: [PATCH v3 5/5] arm: qcom: dts: Enable NAND node on IPQ8064 AP148 platform References: <1421419702-17812-1-git-send-email-architt@codeaurora.org> <1438578498-32254-1-git-send-email-architt@codeaurora.org> <1438578498-32254-6-git-send-email-architt@codeaurora.org> <20150803205829.GA21068@codeaurora.org> In-Reply-To: <20150803205829.GA21068@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1017 Lines: 42 On 8/4/2015 2:28 AM, Stephen Boyd wrote: > On 08/03, Archit Taneja wrote: >> @@ -93,5 +115,19 @@ >> sata@29000000 { >> status = "ok"; >> }; >> + >> + nand@1ac00000 { >> + status = "ok"; >> + >> + pinctrl-0 = <&nand_pins>; >> + pinctrl-names = "default"; >> + >> + nand-ecc-strength = <4>; >> + nand-bus-width = <8>; >> + }; >> }; >> }; >> + >> +&adm_dma { >> + status = "ok"; >> +}; > > I think the preference is to put the full path to the device in > the dts file and then have status = "ok". So please move this > into the soc node and give the correct offset, etc. like we've > done for other nodes. I'll do that. Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/