Date: Tue, 4 Aug 2015 11:20:20 -0400 (EDT)
From: Ulrich Obergfell <uobergfe@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        dzickus@redhat.com, atomlin@redhat.com, jolsa@kernel.org,
        eranian@google.com, cmetcalf@ezchip.com, fweisbec@gmail.com
Message-ID: <390583962.4154938.1438701620927.JavaMail.zimbra@redhat.com>
In-Reply-To: <20150804132626.GE28571@dhcp22.suse.cz>
References: <1438433365-2979-1-git-send-email-uobergfe@redhat.com> <1438433365-2979-2-git-send-email-uobergfe@redhat.com> <20150804132626.GE28571@dhcp22.suse.cz>
Subject: Re: [PATCH 1/4] watchdog: introduce watchdog_park_threads() and
 watchdog_unpark_threads()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: watchdog: introduce watchdog_park_threads() and watchdog_unpark_threads()
Thread-Index: EX2opAQ+gTeiHbP4Urke7SvaF42LkA==
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1048
Lines: 27

> ----- Original Message -----
> From: "Michal Hocko" <mhocko@kernel.org>
...
> On Sat 01-08-15 14:49:22, Ulrich Obergfell wrote:
>> These functions are intended to be used only from inside kernel/watchdog.c
>> to park/unpark all watchdog threads that are specified in watchdog_cpumask.
>
> I would suggest merging this into Patch2. It is usually better to add
> new functions along with their users.

Michal,

watchdog_{park|unpark}_threads are called by watchdog_{suspend|resume}
in Patch 2/4 and by update_watchdog_all_cpus() in Patch 3/4, so I would
have to merge three patches into one, and I would end up with one large
patch and one smaller patch. I think the result would be harder to read,
review and understand. Thus I'd prefer to leave the patches split as they
currently are.

Regards,

Uli
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/