Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752924AbbHDPlM (ORCPT ); Tue, 4 Aug 2015 11:41:12 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:36317 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbbHDPlK (ORCPT ); Tue, 4 Aug 2015 11:41:10 -0400 Date: Tue, 4 Aug 2015 17:41:04 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Guenter Roeck Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck , linux-kernel@vger.kernel.org, Timo Kokkonen , linux-doc@vger.kernel.org, Jonathan Corbet , kernel@pengutronix.de Subject: Re: [PATCH 3/8] watchdog: Introduce WDOG_RUNNING flag Message-ID: <20150804154104.GT9999@pengutronix.de> References: <1438654414-29259-1-git-send-email-linux@roeck-us.net> <1438654414-29259-4-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1438654414-29259-4-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1693 Lines: 37 Hello, On Mon, Aug 03, 2015 at 07:13:29PM -0700, Guenter Roeck wrote: > The WDOG_RUNNING flag is expected to be set by watchdog drivers if > the hardware watchdog is running. If the flag is set, the watchdog > subsystem will ping the watchdog even if the watchdog device is closed. > > The watchdog driver stop function is now optional and may be omitted > if the watchdog can not be stopped. If stopping the watchdog is not > possible but the driver implements a stop function, it is responsible > to set the WDOG_RUNNING flag in its stop function. > > Cc: Timo Kokkonen > Cc: Uwe Kleine-K?nig > Signed-off-by: Guenter Roeck > --- > Documentation/watchdog/watchdog-kernel-api.txt | 19 ++++++++----- > drivers/watchdog/watchdog_core.c | 2 +- > drivers/watchdog/watchdog_dev.c | 39 ++++++++++++++++++++------ > include/linux/watchdog.h | 7 +++++ > 4 files changed, 50 insertions(+), 17 deletions(-) Another thing that I noticed just now after looking at a later patch in this series: Conceptually that worker stuff better fits into watchdog_core.c than watchdog_dev.c, doesn't it? But maybe this separation doesn't make sense anyhow? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/