Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752609AbbHDQKH (ORCPT ); Tue, 4 Aug 2015 12:10:07 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:55363 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbbHDQKE (ORCPT ); Tue, 4 Aug 2015 12:10:04 -0400 Date: Tue, 4 Aug 2015 18:03:00 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, "David S. Miller" , Guenter Roeck , Florian Fainelli , Scott Feldman , Jiri Pirko , linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH net-next 4/4] net: dsa: mv88e6xxx: refactor FDB routines Message-ID: <20150804160300.GB28673@lunn.ch> References: <1438670018-30501-1-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438670018-30501-1-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1379 Lines: 36 On Tue, Aug 04, 2015 at 02:33:38AM -0400, Vivien Didelot wrote: > Refactor mv88e6xxx_port_fdb_{add,del,getnext} to respect the new DSA > switch driver FDB access routines. > > The Marvell 88E6xxx switches support up to 4094 FIDs (from 1 to 0xfff; > FID 0 means that multiple address databases are not being used). So > change the fid_mask for a fid_bitmap of 4096 bits. > > FIDs 1 to num_ports will be reserved for non-bridged ports and bridge > groups (a bridge group gets the FID of its first member). The remaining > bits will then be used for VLANs. > > Also do not consider an address (yet) if it is trunk mapped. > > This change is a need to welcome the future support for hardware VLANs. This patch seems to contain more than one logical set of changes. That is making it hard to review. Can you split it up a bit. The GLOBAL_ATU_DATA_TRUNK stuff can be in a patch of its own. unsigned char *addr to u8 addr[ETH_ALEN]. The change fid_mask to fid_bitmap ... ... The refactoring Basically, we want to see lots of little patches which are obvious correct, rather than one big patch where it is not obvious. Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/