Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755377AbbHDRmm (ORCPT ); Tue, 4 Aug 2015 13:42:42 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54785 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752584AbbHDRmj (ORCPT ); Tue, 4 Aug 2015 13:42:39 -0400 Date: Tue, 4 Aug 2015 18:42:26 +0100 From: Mark Brown To: Leilk Liu Cc: Mark Rutland , Matthias Brugger , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org Message-ID: <20150804174226.GE20873@sirena.org.uk> References: <1438167874-1305-1-git-send-email-leilk.liu@mediatek.com> <1438167874-1305-2-git-send-email-leilk.liu@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ecKHkrog8duCxGt3" Content-Disposition: inline In-Reply-To: <1438167874-1305-2-git-send-email-leilk.liu@mediatek.com> X-Cookie: Please take note: User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1718 Lines: 49 --ecKHkrog8duCxGt3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 29, 2015 at 07:04:32PM +0800, Leilk Liu wrote: > Signed-off-by: Leilk Liu Please use subject lines reflecting the style for the subsystem so people can spot if patches are relevant to them. > +- clocks: phandles to input clocks. > + > +- clock-names: tuple listing input clock names. > + Required elements: "main" ...and there are no optional values? > +- pad-select: should specify spi pad used, only required for MT8173. > + This value should be 0~3. What do the values 0-3 mean? I guess it's the value for some register or other part of the device, the binding should say so people can go and check the datasheet, schematic or whatever to figure out what to set. This property should be optional, not required --ecKHkrog8duCxGt3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVwPmCAAoJECTWi3JdVIfQZl4H/3NcxpNuKbxoyAvXkigb2RtW yJp51kfljB3TuWVtMZ+ixwMkoL49uQI/w3MZd2N6OG5x7NL4hQmIU57pscbjnr+v XdIecCybNID3M4D86PEDkYYjJww+0tSgASOi6VeK4UFmhkNk6QA5CmPDVamAdmRI cvV2EebMbeWxrNbRwkIWgh77xUTy9CG1J1PWxXD2iYkEHpBtTnk3Ax8YQM5de2cF UvuwIYnSd0QylyJXsoai+M2h47U2ybC5qxE1udJChxt9PMed7XaMbxV0p/6DVUTN zJwTQAGogwQ18BCkkY36JPAYx5fkPP5BEiQu1dt9FGBsCz2HzgqrDx4SQtvVfWM= =7Ebn -----END PGP SIGNATURE----- --ecKHkrog8duCxGt3-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/