Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754929AbbHDRxm (ORCPT ); Tue, 4 Aug 2015 13:53:42 -0400 Received: from mail.kernel.org ([198.145.29.136]:54146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752215AbbHDRxj (ORCPT ); Tue, 4 Aug 2015 13:53:39 -0400 Date: Tue, 4 Aug 2015 14:53:34 -0300 From: Arnaldo Carvalho de Melo To: "Liang, Kan" Cc: Jiri Olsa , "a.p.zijlstra@chello.nl" , "luto@kernel.org" , "mingo@redhat.com" , "eranian@google.com" , "ak@linux.intel.com" , "mark.rutland@arm.com" , "Hunter, Adrian" , "jolsa@kernel.org" , "namhyung@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V3 3/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D Message-ID: <20150804175334.GD3126@kernel.org> References: <1438082975-47730-1-git-send-email-kan.liang@intel.com> <1438082975-47730-4-git-send-email-kan.liang@intel.com> <20150729125329.GH9606@krava.brq.redhat.com> <20150729154322.GI575@kernel.org> <20150729161242.GJ575@kernel.org> <37D7C6CF3E00A74B8858931C1DB2F077018D186D@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077018D186D@SHSMSX103.ccr.corp.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1360 Lines: 32 Em Tue, Aug 04, 2015 at 05:07:40PM +0000, Liang, Kan escreveu: > > Em Wed, Jul 29, 2015 at 12:43:22PM -0300, Arnaldo Carvalho de Melo > > > I'll take a look at how interesting it would be to have a > > > evsel->evlist, that if NULL means the evsel is freestanding, but when > > > it is linked to an evlist, then it will be there. This way we wouldn't > > > have to pass (evlist, evsel) when the main purpose of a function is > > > about an evsel but we need information that is logically associated to > > > all evsels in a list, i.e. that is in evsel->evlist. > > There are no cases where a function receives (evsel, evlist) with that evlist > > containing that evsel :-\ > > Perhaps this will be the first, i.e. rename perf_session_env to perf_env, > > then store it in evlist->env, then when processing something where we > > have a evsel or evlist we can access that env from: > > evsel->evlist->env; > > Will continue after lunch, trying to prototype what I just described. > Hi Arnaldo, > Have you got a chance to implement the prototype for evlist->env? Not really, got sidetracked :-\ - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/