Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754398AbbHDV0e (ORCPT ); Tue, 4 Aug 2015 17:26:34 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:36750 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752621AbbHDV0d (ORCPT ); Tue, 4 Aug 2015 17:26:33 -0400 MIME-Version: 1.0 In-Reply-To: <20150804195631.GB28564@amd> References: <1503739.gVWYM3p8QD@avalon> <1643821.fnPPMYQxCt@avalon> <20150728152225.GA454@mtj.duckdns.org> <3561824.rKlMSGlkdL@avalon> <20150804195631.GB28564@amd> Date: Tue, 4 Aug 2015 14:26:31 -0700 Message-ID: Subject: Re: Is devm_* broken ? From: Dmitry Torokhov To: Pavel Machek Cc: Laurent Pinchart , Tejun Heo , Dan Williams , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1567 Lines: 36 On Tue, Aug 4, 2015 at 12:56 PM, Pavel Machek wrote: > On Tue 2015-07-28 20:05:49, Laurent Pinchart wrote: >> On Tuesday 28 July 2015 11:22:25 Tejun Heo wrote: >> > On Tue, Jul 28, 2015 at 05:16:16PM +0300, Laurent Pinchart wrote: >> > > Using devm_kzalloc() in such a way has value though, and reverting drivers >> > > to the pre-devm memory allocation code would make error handling and >> > > cleanup code paths more complex again. Should we introduce a managed >> > > allocator for that purpose that would have a lifespan explicitly handled >> > > by drivers ? >> > >> > I don't know. Sure, we can have memory allocations which are tied to >> > open file; however, the distinction between that and regular devm >> > resources, which can't linger on no matter what, would be subtle and >> > confusing. IMHO, a better approach would be implmenting generic >> > revoke feature and sever open files on driver detach so that >> > everything can be shutdown then. >> >> Sounds like a topic for the kernel summit :-) I'll send a proposal. > > Hmm. But that means that devm_ everything is broken for 6 months or > so, right? > > Does it mean we should stop taking new devm_ conversions at the very > least? No, we should continue carefully review them and take the ones that make sense. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/