Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754517AbbHDWJk (ORCPT ); Tue, 4 Aug 2015 18:09:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57718 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753264AbbHDWJi (ORCPT ); Tue, 4 Aug 2015 18:09:38 -0400 Date: Tue, 4 Aug 2015 15:09:37 -0700 From: Andrew Morton To: Jaewon Kim Cc: mgorman@suse.de, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com Subject: Re: [PATCH v2] vmscan: fix increasing nr_isolated incurred by putback unevictable pages Message-Id: <20150804150937.ee3b62257e77911a2f41a48e@linux-foundation.org> In-Reply-To: <1438684808-12707-1-git-send-email-jaewon31.kim@samsung.com> References: <1438684808-12707-1-git-send-email-jaewon31.kim@samsung.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1141 Lines: 31 On Tue, 04 Aug 2015 19:40:08 +0900 Jaewon Kim wrote: > reclaim_clean_pages_from_list() assumes that shrink_page_list() returns > number of pages removed from the candidate list. But shrink_page_list() > puts back mlocked pages without passing it to caller and without > counting as nr_reclaimed. This incurrs increasing nr_isolated. > To fix this, this patch changes shrink_page_list() to pass unevictable > pages back to caller. Caller will take care those pages. > > .. > > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1157,7 +1157,7 @@ cull_mlocked: > if (PageSwapCache(page)) > try_to_free_swap(page); > unlock_page(page); > - putback_lru_page(page); > + list_add(&page->lru, &ret_pages); > continue; > > activate_locked: Is this going to cause a whole bunch of mlocked pages to be migrated whereas in current kernels they stay where they are? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/