Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958AbbHDXGn (ORCPT ); Tue, 4 Aug 2015 19:06:43 -0400 Received: from TYO202.gate.nec.co.jp ([210.143.35.52]:65084 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753798AbbHDXGm convert rfc822-to-8bit (ORCPT ); Tue, 4 Aug 2015 19:06:42 -0400 From: Naoya Horiguchi To: Wang Xiaoqiang CC: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH] memory-failure/hwpoison_user_mappings: move the comment about swap cache pages' check to proper location Thread-Topic: [PATCH] memory-failure/hwpoison_user_mappings: move the comment about swap cache pages' check to proper location Thread-Index: AQHQzq/nujaGZqRyyUyvMZUkr8Dr0p37386A Date: Tue, 4 Aug 2015 23:05:18 +0000 Message-ID: <20150804230517.GA13606@hori1.linux.bs1.fc.nec.co.jp> References: <20150804202038.0ca2777e@hp> In-Reply-To: <20150804202038.0ca2777e@hp> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.128.101.15] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1658 Lines: 56 On Tue, Aug 04, 2015 at 08:20:38PM +0800, Wang Xiaoqiang wrote: > Hi Naoya, > > This patch just move the comment about swap cache pages' check to the > proper location in 'hwpoison_user_mappings' function. > > Signed-off-by: Wang Xiaoqiang Thank you for finding out this. Acked-by: Naoya Horiguchi > --- > mm/memory-failure.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 1cf7f29..3253abb 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -945,10 +945,6 @@ static int hwpoison_user_mappings(struct page *p, unsigned long pfn, > if (!(PageLRU(hpage) || PageHuge(p))) > return SWAP_SUCCESS; > > - /* > - * This check implies we don't kill processes if their pages > - * are in the swap cache early. Those are always late kills. > - */ > if (!page_mapped(hpage)) > return SWAP_SUCCESS; > > @@ -957,6 +953,10 @@ static int hwpoison_user_mappings(struct page *p, unsigned long pfn, > return SWAP_FAIL; > } > > + /* > + * This check implies we don't kill processes if their pages > + * are in the swap cache early. Those are always late kills. > + */ > if (PageSwapCache(p)) { > printk(KERN_ERR > "MCE %#lx: keeping poisoned page in swap cache\n", pfn); > -- > 1.7.10.4 > > > > -- > thx! > Wang Xiaoqiang > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/