Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752935AbbHDX4a (ORCPT ); Tue, 4 Aug 2015 19:56:30 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:36732 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbbHDX43 (ORCPT ); Tue, 4 Aug 2015 19:56:29 -0400 Date: Wed, 5 Aug 2015 08:57:05 +0900 From: Sergey Senozhatsky To: Salah Triki Cc: minchan@kernel.org, ngupta@vflare.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky , Sergey Senozhatsky Subject: Re: [PATCH] zram: Replace pr_* with dev_* Message-ID: <20150804235705.GB4430@swordfish> References: <1438716174-3684-1-git-send-email-salah.triki@acm.org> <20150804234225.GA4430@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150804234225.GA4430@swordfish> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1505 Lines: 59 On (08/05/15 08:42), Sergey Senozhatsky wrote: > what's the benefit? and apart from that I don't understand why do you replace some pr_info() with dev_warn(). f.e. [..] > > if (!zcomp_set_max_streams(zram->comp, num)) { > > - pr_info("Cannot change max compression streams\n"); > > + dev_warn(dev, "Cannot change max compression streams to %d", > > + num); ^^^ > > ret = -EINVAL; > > goto out; > > } > > @@ -368,7 +369,7 @@ static ssize_t comp_algorithm_store(struct device *dev, > > down_write(&zram->init_lock); > > if (init_done(zram)) { > > up_write(&zram->init_lock); > > - pr_info("Can't change algorithm for initialized device\n"); > > + dev_warn(dev, "Can't change algorithm for initialized device"); ^^^ [..] and sometimes you don't -- changing pr_info() to dev_info(). > > if (IS_ERR(comp)) { > > - pr_info("Cannot initialise %s compressing backend\n", > > + dev_info(dev, "Cannot initialise %s compressing backend", > > zram->compressor); ^^^ [..] and then again... > > down_write(&zram->init_lock); > > if (init_done(zram)) { > > - pr_info("Cannot change disksize for initialized device\n"); > > + dev_warn(dev, "Cannot change disksize for initialized device"); ^^^ [..] -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/