Message-ID: <1438737365.24137.0.camel@perches.com>
Subject: Re: [PATCH] zram: Replace pr_* with dev_*
From: Joe Perches <joe@perches.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Salah Triki <salah.triki@acm.org>, minchan@kernel.org, ngupta@vflare.org,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Date: Tue, 04 Aug 2015 18:16:05 -0700
In-Reply-To: <20150804235705.GB4430@swordfish>
References: <1438716174-3684-1-git-send-email-salah.triki@acm.org>
	 <20150804234225.GA4430@swordfish> <20150804235705.GB4430@swordfish>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 826
Lines: 24

On Wed, 2015-08-05 at 08:57 +0900, Sergey Senozhatsky wrote:
> On (08/05/15 08:42), Sergey Senozhatsky wrote:
> > what's the benefit?
> 
> and apart from that I don't understand why do you replace some
> pr_info() with dev_warn(). f.e.

And besides that, the formats should not be changed
and still require a '\n' termination to avoid
possible interleaving.

> [..]
> > >  		if (!zcomp_set_max_streams(zram->comp, num)) {
> > > -			pr_info("Cannot change max compression streams\n");
> > > +			dev_warn(dev, "Cannot change max compression streams to %d",
> > > +				num);

etc...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/