Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbbHEI33 (ORCPT ); Wed, 5 Aug 2015 04:29:29 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:37255 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750989AbbHEI30 (ORCPT ); Wed, 5 Aug 2015 04:29:26 -0400 Date: Wed, 5 Aug 2015 09:29:11 +0100 From: Javi Merino To: Eduardo Valentin , Dmitry Torokhov Cc: Zhang Rui , Lukasz Majewski , Peter Feuerer , Sascha Hauer , Punit Agrawal , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] thermal: power_allocator: do not use devm* interfaces Message-ID: <20150805082910.GB2688@e104805> References: <20150804163340.GA33245@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150804163340.GA33245@dtor-ws> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 693 Lines: 18 On Tue, Aug 04, 2015 at 05:33:40PM +0100, Dmitry Torokhov wrote: > The code in question is called outside of standard driver > probe()/remove() callbacks and thus will not benefit from use of devm* > infrastructure. > > Signed-off-by: Dmitry Torokhov We added the devm* calls because Eduardo asked for them in the review. I don't have a strong opinion regarding this, I'll leave the decision to Eduardo. Cheers, Javi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/