Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752122AbbHEIiF (ORCPT ); Wed, 5 Aug 2015 04:38:05 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:47050 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751073AbbHEIiC (ORCPT ); Wed, 5 Aug 2015 04:38:02 -0400 Date: Wed, 5 Aug 2015 09:37:55 +0100 From: Javi Merino To: Dmitry Torokhov Cc: Eduardo Valentin , Zhang Rui , Srinivas Pandruvada , Tushar Dave , Lan Tianyu , Punit Agrawal , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] thermal: remove power allocator from list of default governors Message-ID: <20150805083755.GC2688@e104805> References: <20150804163921.GA36852@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150804163921.GA36852@dtor-ws> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1740 Lines: 45 On Tue, Aug 04, 2015 at 05:39:21PM +0100, Dmitry Torokhov wrote: > As it currently stands the power allocator governor can not handle > thermal zones that are not specifically crafted and therefore can not be > used as a default governor. > > Users need to explicitly enable this governor for thermal zones that do > have enough information for its operation. > > Signed-off-by: Dmitry Torokhov > --- > drivers/thermal/Kconfig | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 0390044..34d05d3 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -82,14 +82,6 @@ config THERMAL_DEFAULT_GOV_USER_SPACE > Select this if you want to let the user space manage the > platform thermals. > > -config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR > - bool "power_allocator" > - select THERMAL_GOV_POWER_ALLOCATOR > - help > - Select this if you want to control temperature based on > - system and device power allocation. This governor can only > - operate on cooling devices that implement the power API. > - Currently the only way we have for a thermal zone configured from device tree to use a governor from the kernel boot is by using THERMAL_DEFAULT_GOV_*. If we remove this option some devices won't have a workable thermal framework until userspace is up and running. Would you rather have the power allocator governor accept every thermal zone? Cheers, Javi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/