Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbbHEIsD (ORCPT ); Wed, 5 Aug 2015 04:48:03 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:34907 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751493AbbHEIsA (ORCPT ); Wed, 5 Aug 2015 04:48:00 -0400 Message-ID: <55C1CDB9.5010106@linaro.org> Date: Wed, 05 Aug 2015 14:17:53 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Lee Jones CC: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, devicetree@vger.kernel.org, broonie@kernel.org, k.kozlowski@samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH-v2 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1 References: <1437495782-15767-1-git-send-email-vaibhav.hiremath@linaro.org> <1437495782-15767-3-git-send-email-vaibhav.hiremath@linaro.org> <20150723155432.GV3436@x1> In-Reply-To: <20150723155432.GV3436@x1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1472 Lines: 47 On Thursday 23 July 2015 09:24 PM, Lee Jones wrote: > On Tue, 21 Jul 2015, Vaibhav Hiremath wrote: > >> 88PM860 device supports dual phase mode on BUCK1 output. >> In normal usecase, BUCK1A and BUCK1B operates independently with 3A >> capacity. And they both can work as a dual phase providing 6A capacity. >> >> This patch updates the regulator driver to read the respective >> DT property and enable dual-phase mode on BUCK1. >> >> Note that, this is init time (one time) initialization. >> >> Signed-off-by: Vaibhav Hiremath >> --- >> drivers/regulator/88pm800.c | 31 +++++++++++++++++++++++++++++++ >> include/linux/mfd/88pm80x.h | 3 +++ >> 2 files changed, 34 insertions(+) > > [...] > >> diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h >> index a92d173..05d9bad 100644 >> --- a/include/linux/mfd/88pm80x.h >> +++ b/include/linux/mfd/88pm80x.h >> @@ -295,6 +295,9 @@ enum { >> #define PM860_BUCK4_MISC2 (0x82) >> #define PM860_BUCK4_FULL_DRV BIT(2) >> >> +#define PM860_BUCK1_MISC (0x8E) > > Why the over-bracketing? > No specific reason, just wanted to be consistent with other definitions in the file. Anyway, will remove it in V3. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/