Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752569AbbHEIvg (ORCPT ); Wed, 5 Aug 2015 04:51:36 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34984 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbbHEIvd (ORCPT ); Wed, 5 Aug 2015 04:51:33 -0400 Message-ID: <55C1CE8E.9000601@linaro.org> Date: Wed, 05 Aug 2015 14:21:26 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: linux-arm-kernel@lists.infradead.org CC: robert.jarzmik@free.fr, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, wsa@the-dreams.de, "Jett.Zhou" , Yi Zhang Subject: Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support References: <1437482466-16126-1-git-send-email-vaibhav.hiremath@linaro.org> <1437482466-16126-6-git-send-email-vaibhav.hiremath@linaro.org> In-Reply-To: <1437482466-16126-6-git-send-email-vaibhav.hiremath@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1365 Lines: 40 On Tuesday 21 July 2015 06:11 PM, Vaibhav Hiremath wrote: > With addition of PXA910 family of devices, the TWSI module supports > SCL clock adjustment using ILCR register. > > This patch enables the control and configuration of ICLR through DT > properties, > > i2c-sclk-high-time-ns: > SCLK high time (tHigh), for standard/fast/high speed mode > i2c-sclk-low-time-ns: > SCLK low time (tLow), for standard/fast/high speed mode > > Note that in case of standard and fast mod, the tLow and tHigh counters > are same, and software will use tLow value. > > Also, brought up devm_clk_get() fn above i2c_pxa_probe_dt(), as it > uses clk rate for timing calculations. > > Signed-off-by: Vaibhav Hiremath > Signed-off-by: Jett.Zhou > Signed-off-by: Yi Zhang > --- > drivers/i2c/busses/i2c-pxa.c | 69 ++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 63 insertions(+), 6 deletions(-) > Robert, It would be helpful if you can test this patch-series and confirm that it now fixes the NULL pointer deference issue. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/