Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbbHEKJZ (ORCPT ); Wed, 5 Aug 2015 06:09:25 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:32221 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbbHEKJX (ORCPT ); Wed, 5 Aug 2015 06:09:23 -0400 X-IronPort-AV: E=Sophos;i="5.15,615,1432598400"; d="scan'208";a="291522297" Date: Wed, 5 Aug 2015 11:07:56 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Boris Ostrovsky CC: Julien Grall , , , , , Russell King , "Konrad Rzeszutek Wilk" , David Vrabel , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Dmitry Torokhov , Wei Liu , Juergen Gross , "James E.J. Bottomley" , "Greg Kroah-Hartman" , Jiri Slaby , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , , , , , , Subject: Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies In-Reply-To: <55C147DD.7000600@oracle.com> Message-ID: References: <1438711972-18752-1-git-send-email-julien.grall@citrix.com> <1438711972-18752-5-git-send-email-julien.grall@citrix.com> <55C147DD.7000600@oracle.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 36 On Tue, 4 Aug 2015, Boris Ostrovsky wrote: > On 08/04/2015 02:12 PM, Julien Grall wrote: > > /* > > * We detect special mappings in one of two ways: > > @@ -217,9 +232,13 @@ static inline unsigned long bfn_to_local_pfn(unsigned > > long mfn) > > /* VIRT <-> MACHINE conversion */ > > #define virt_to_machine(v) (phys_to_machine(XPADDR(__pa(v)))) > > -#define virt_to_pfn(v) (PFN_DOWN(__pa(v))) > > #define virt_to_mfn(v) (pfn_to_mfn(virt_to_pfn(v))) > > #define mfn_to_virt(m) (__va(mfn_to_pfn(m) << PAGE_SHIFT)) > > +#define virt_to_pfn(v) (PFN_DOWN(__pa(v))) > > This looks like unnecessary change. > > > > diff --git a/drivers/video/fbdev/xen-fbfront.c > > b/drivers/video/fbdev/xen-fbfront.c > > index 09dc447..25e3cce 100644 > > --- a/drivers/video/fbdev/xen-fbfront.c > > +++ b/drivers/video/fbdev/xen-fbfront.c > > @@ -539,7 +539,7 @@ static int xenfb_remove(struct xenbus_device *dev) > > static unsigned long vmalloc_to_mfn(void *address) > > { > > - return pfn_to_mfn(vmalloc_to_pfn(address)); > > + return pfn_to_gfn(vmalloc_to_pfn(address)); > > } > > Are you sure? This will return vmalloc_to_pfn(address)). I think that is OK: there is no behavioural change here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/