Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751808AbbHEKM4 (ORCPT ); Wed, 5 Aug 2015 06:12:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46355 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751218AbbHEKMz (ORCPT ); Wed, 5 Aug 2015 06:12:55 -0400 Subject: Re: [PATCH v2 8/9] KVM: MMU: fully check zero bits for sptes To: Xiao Guangrong References: <1438747467-25425-1-git-send-email-guangrong.xiao@linux.intel.com> <1438747467-25425-9-git-send-email-guangrong.xiao@linux.intel.com> Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, ru.pchel@gmail.com From: Paolo Bonzini Message-ID: <55C1E1A3.4020300@redhat.com> Date: Wed, 5 Aug 2015 12:12:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1438747467-25425-9-git-send-email-guangrong.xiao@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 29 On 05/08/2015 06:04, Xiao Guangrong wrote: > - for_each_shadow_entry_lockless(vcpu, addr, iterator, spte) > + for_each_shadow_entry_lockless(vcpu, addr, iterator, spte) { > + leaf = iterator.level; > + > + if (!root) > + root = leaf; > + > + sptes[leaf - 1] = spte; > + I'm a bit undecided between this and open-coding the macro: for (shadow_walk_init(&iterator, vcpu, addr), root = iterator.level; shadow_walk_okay(&iterator); __shadow_walk_next(&iterator, spte)) { leaf = iterator.level; spte = mmu_spte_get_lockless(iterator.sptep); Any second opinions? Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/