Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752391AbbHEKcK (ORCPT ); Wed, 5 Aug 2015 06:32:10 -0400 Received: from smtp.citrix.com ([66.165.176.89]:20466 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881AbbHEKcG (ORCPT ); Wed, 5 Aug 2015 06:32:06 -0400 X-IronPort-AV: E=Sophos;i="5.15,615,1432598400"; d="scan'208";a="288231777" Message-ID: <55C1E5ED.10103@citrix.com> Date: Wed, 5 Aug 2015 11:31:09 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Stefano Stabellini CC: , , , Russell King , Konrad Rzeszutek Wilk , Boris Ostrovsky , David Vrabel , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , , Subject: Re: [PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address References: <1438711972-18752-1-git-send-email-julien.grall@citrix.com> <1438711972-18752-3-git-send-email-julien.grall@citrix.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1016 Lines: 33 Hi Stefano, On 05/08/15 10:49, Stefano Stabellini wrote: >> /* VIRT <-> MACHINE conversion */ >> #define virt_to_mfn(v) (pfn_to_mfn(virt_to_pfn(v))) >> @@ -96,7 +115,7 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn) >> >> bool xen_arch_need_swiotlb(struct device *dev, >> unsigned long pfn, >> - unsigned long mfn); >> + unsigned long dfn); >> unsigned long xen_get_swiotlb_free_pages(unsigned int order); > > You missed a bunch of dfn->bfn renamings. Sorry, I forgot to double check that before sending the patch. I will fix it in the next version. > Aside from those and the commit message error: > > Reviewed-by: Stefano Stabellini Thank you! Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/