Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526AbbHEKxa (ORCPT ); Wed, 5 Aug 2015 06:53:30 -0400 Received: from lists.s-osg.org ([54.187.51.154]:56109 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbbHEKx2 (ORCPT ); Wed, 5 Aug 2015 06:53:28 -0400 Subject: Re: [PATCH 1/2] mfd: s2mps11: Add manual shutdown method for Odroid XU3 To: Krzysztof Kozlowski , Sangbeom Kim , Krzysztof Kozlowski , Lee Jones , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim , linux-arm-kernel@lists.infradead.org References: <1438605447-6836-1-git-send-email-k.kozlowski.k@gmail.com> <1438605447-6836-2-git-send-email-k.kozlowski.k@gmail.com> Cc: Anand Moon From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Message-ID: <55C1EB20.3040400@osg.samsung.com> Date: Wed, 5 Aug 2015 12:53:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1438605447-6836-2-git-send-email-k.kozlowski.k@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2127 Lines: 57 Hello Krzysztof, On 08/03/2015 02:37 PM, Krzysztof Kozlowski wrote: > On Odroid XU3 board (with S2MPS11 PMIC) the PWRHOLD bit in CTRL1 > register must be manually set to 0 before initiating power off sequence. > > One of usual power down methods for Exynos based devices looks like: > 1. PWRHOLD pin of PMIC is connected to PSHOLD of Exynos. > 2. Exynos holds up this pin during system operation. > 3. ACOKB pin of PMIC is pulled up to VBATT and optionally to pin in > other device. > 4. When PWRHOLD/PSHOLD goes low, the PMIC will turn off the power if > ACOKB goes high. > > On Odroid XU3 family the difference is in (3) - the ACOKB is grounded. > This means that PMIC must manually set PWRHOLD field to low and then > wait for signal from Application Processor (the usual change in > PWRHOLD/PSHOLD pin will actually cut off the power). > Is nice to finally have an explanation about why this is needed. > The patch adds respective binding allowing Odroid XU3 device to be > powered off. > > Signed-off-by: Krzysztof Kozlowski > Reported-by: Anand Moon > > --- > > Patch is losely based on patch in Hardkernel repository [0] and previous > work of Anand Moon [1]. > > [0] https://github.com/hardkernel/linux/commit/6897e62ba328bd1c8c095d918101863250cd73e7 > [1] http://www.spinics.net/lists/linux-samsung-soc/msg45959.html > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 4 +++ > drivers/mfd/sec-core.c | 31 +++++++++++++++++++++++ > include/linux/mfd/samsung/core.h | 2 ++ > include/linux/mfd/samsung/s2mps11.h | 1 + > 4 files changed, 38 insertions(+) > The patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/