Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752305AbbHEMYD (ORCPT ); Wed, 5 Aug 2015 08:24:03 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:39723 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbbHEMYA (ORCPT ); Wed, 5 Aug 2015 08:24:00 -0400 Message-ID: <55C1FF54.8060409@oracle.com> Date: Wed, 05 Aug 2015 08:19:32 -0400 From: Boris Ostrovsky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Julien Grall , xen-devel@lists.xenproject.org CC: linux-fbdev@vger.kernel.org, "H. Peter Anvin" , Jiri Slaby , stefano.stabellini@eu.citrix.com, Russell King , linux-scsi@vger.kernel.org, x86@kernel.org, Tomi Valkeinen , linux-input@vger.kernel.org, Jean-Christophe Plagniol-Villard , ian.campbell@citrix.com, Konrad Rzeszutek Wilk , "James E.J. Bottomley" , Thomas Gleixner , Ingo Molnar , linux-arm-kernel@lists.infradead.org, Juergen Gross , Wei Liu , Greg Kroah-Hartman , Dmitry Torokhov , linux-kernel@vger.kernel.org, David Vrabel , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, =?windows-1252?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies References: <1438711972-18752-1-git-send-email-julien.grall@citrix.com> <1438711972-18752-5-git-send-email-julien.grall@citrix.com> <55C147DD.7000600@oracle.com> <55C1EA95.5060504@citrix.com> In-Reply-To: <55C1EA95.5060504@citrix.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1395 Lines: 42 On 08/05/2015 06:51 AM, Julien Grall wrote: > >>> diff --git a/drivers/video/fbdev/xen-fbfront.c >>> b/drivers/video/fbdev/xen-fbfront.c >>> index 09dc447..25e3cce 100644 >>> --- a/drivers/video/fbdev/xen-fbfront.c >>> +++ b/drivers/video/fbdev/xen-fbfront.c >>> @@ -539,7 +539,7 @@ static int xenfb_remove(struct xenbus_device *dev) >>> static unsigned long vmalloc_to_mfn(void *address) >>> { >>> - return pfn_to_mfn(vmalloc_to_pfn(address)); >>> + return pfn_to_gfn(vmalloc_to_pfn(address)); >>> } >> Are you sure? This will return vmalloc_to_pfn(address)). > I guess you mean vmalloc_to_mfn will return vmalloc_to_pfn? > > If so, it will be only the case on auto-translated case (because pfn == > gfn). In the case of PV, the mfn will be returned. How will mfn be returned on PV when pfn_to_gfn() is an identity function? static inline unsigned long pfn_to_gfn(unsigned long pfn) { return pfn; } -boris > > Although, this function is misnamed. It's fixed in a follow-up patch > (see #6) because it's required more renaming than this function. I > didn't want to add such changes within this patch. > > Regards, > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/