Date: Wed, 5 Aug 2015 15:34:43 +0200
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 3/5] KVM: add KVM_USER_EXIT vm ioctl for userspace exit
Message-ID: <20150805133442.GA31952@potion.brq.redhat.com>
References: <1438780877-31838-1-git-send-email-rkrcmar@redhat.com>
 <1438780877-31838-4-git-send-email-rkrcmar@redhat.com>
 <55C20FD2.8020607@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <55C20FD2.8020607@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 783
Lines: 23

2015-08-05 15:29+0200, Paolo Bonzini:
> On 05/08/2015 15:21, Radim Krčmář wrote:
>> +	kvm_for_each_vcpu(idx, vcpu, kvm)
>> +		if (vcpu->vcpu_id == vcpu_id) {
>> +			kvm_make_request(KVM_REQ_EXIT, vcpu);
>> +			kvm_vcpu_kick(vcpu);
>> +
>> +			return 0;
>> +		}
>> +
> 
> Why not a vcpu ioctl?  kvm_for_each_vcpu can become pretty expensive if
> you have a few dozen VCPUs.

Yeah, it will be slow, the only bright side is low frequency of calls.

vcpu ioctl should only be issued by the vcpu thread so it would
significantly limit use.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/