Subject: Re: [PATCH 3/5] KVM: add KVM_USER_EXIT vm ioctl for userspace exit
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
References: <1438780877-31838-1-git-send-email-rkrcmar@redhat.com>
 <1438780877-31838-4-git-send-email-rkrcmar@redhat.com>
 <55C20FD2.8020607@redhat.com> <20150805133442.GA31952@potion.brq.redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55C211EB.2030704@redhat.com>
Date: Wed, 5 Aug 2015 15:38:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <20150805133442.GA31952@potion.brq.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1389
Lines: 43


On 05/08/2015 15:34, Radim Krčmář wrote:
> 2015-08-05 15:29+0200, Paolo Bonzini:
>> On 05/08/2015 15:21, Radim Krčmář wrote:
>>> +	kvm_for_each_vcpu(idx, vcpu, kvm)
>>> +		if (vcpu->vcpu_id == vcpu_id) {
>>> +			kvm_make_request(KVM_REQ_EXIT, vcpu);
>>> +			kvm_vcpu_kick(vcpu);
>>> +
>>> +			return 0;
>>> +		}
>>> +
>>
>> Why not a vcpu ioctl?  kvm_for_each_vcpu can become pretty expensive if
>> you have a few dozen VCPUs.
> 
> Yeah, it will be slow, the only bright side is low frequency of calls.
> 
> vcpu ioctl should only be issued by the vcpu thread so it would
> significantly limit use.

That's a general limitation, but you can lift it for particular ioctls.

See in particular this:

#if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MIPS)
        /*
         * Special cases: vcpu ioctls that are asynchronous to vcpu execution,
         * so vcpu_load() would break it.
         */
        if (ioctl == KVM_S390_INTERRUPT || ioctl == KVM_S390_IRQ || ioctl == KVM_INTERRUPT)
                return kvm_arch_vcpu_ioctl(filp, ioctl, arg);
#endif

You can add an "if (ioctl == KVM_USER_EXIT)" before.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/