Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753215AbbHENnY (ORCPT ); Wed, 5 Aug 2015 09:43:24 -0400 Received: from mail-la0-f51.google.com ([209.85.215.51]:35895 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752671AbbHENnW (ORCPT ); Wed, 5 Aug 2015 09:43:22 -0400 Message-ID: <55C212F6.40504@linaro.org> Date: Wed, 05 Aug 2015 15:43:18 +0200 From: Tomasz Nowicki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Rafael J. Wysocki" , David Daney CC: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Len Brown , Robert Richter , David Daney Subject: Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call. References: <1438729319-9146-1-git-send-email-ddaney.cavm@gmail.com> <5621301.c1YGTkGNQk@vostro.rjw.lan> In-Reply-To: <5621301.c1YGTkGNQk@vostro.rjw.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1162 Lines: 29 On 05.08.2015 15:48, Rafael J. Wysocki wrote: > On Tuesday, August 04, 2015 04:01:59 PM David Daney wrote: >> From: Tomasz Nowicki >> >> Fixes the following build error when building drivers as modules: >> >> ERROR: "acpi_dev_prop_read_single" [drivers/net/phy/mdio-octeon.ko] undefined! >> ERROR: "acpi_dev_prop_read_single" [drivers/net/ethernet/cavium/thunder/thunder_bgx.ko] undefined! > > Can you please tell me why the drivers in question use that function > directly, although they aren't supposed to? > > Clearly, their authors had not tried to build them as modules or they > would have noticed the problem at the development stage already. > > What would be wrong with using the generic device properties API instead? > Yes, you are right. We should use: int device_property_read_u64_array(struct device *dev, const char *propname, u64 *val, size_t nval); Regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/