Date: Wed, 5 Aug 2015 15:48:22 +0200
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 3/5] KVM: add KVM_USER_EXIT vm ioctl for userspace exit
Message-ID: <20150805134821.GA1481@potion.brq.redhat.com>
References: <1438780877-31838-1-git-send-email-rkrcmar@redhat.com>
 <1438780877-31838-4-git-send-email-rkrcmar@redhat.com>
 <55C20FD2.8020607@redhat.com>
 <20150805133442.GA31952@potion.brq.redhat.com>
 <55C211EB.2030704@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <55C211EB.2030704@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1033
Lines: 26

2015-08-05 15:38+0200, Paolo Bonzini:
> On 05/08/2015 15:34, Radim Krčmář wrote:
>> vcpu ioctl should only be issued by the vcpu thread so it would
>> significantly limit use.
> 
> That's a general limitation, but you can lift it for particular ioctls.
> 
> See in particular this:
> 
> #if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MIPS)
>         /*
>          * Special cases: vcpu ioctls that are asynchronous to vcpu execution,
>          * so vcpu_load() would break it.
>          */
>         if (ioctl == KVM_S390_INTERRUPT || ioctl == KVM_S390_IRQ || ioctl == KVM_INTERRUPT)
>                 return kvm_arch_vcpu_ioctl(filp, ioctl, arg);
> #endif
> 
> You can add an "if (ioctl == KVM_USER_EXIT)" before.

Thanks, it looks to be safe, I'll put it in v2.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/