Message-ID: <BLU436-SMTP410048B421910920AB4469B9750@phx.gbl>
Date: Wed, 5 Aug 2015 22:19:35 +0800
From: Chen Gang <xili_gchen_5257@hotmail.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
CC: starvik@axis.com, jespern@axis.com, linux-cris-kernel@axis.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cris: arch-v10: kgdb: Add volatile for static variable
 is_dyn_brkp
References: <201508041501.t74F1MH3026171@ignucius.se.axis.com>
In-Reply-To: <201508041501.t74F1MH3026171@ignucius.se.axis.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1220
Lines: 34

On 8/4/15 23:01, Hans-Peter Nilsson wrote:
>> From: Chen Gang <xili_gchen_5257@hotmail.com>
>> Date: Fri, 10 Jul 2015 23:50:07 +0200
> 
>> Within one C file, current gcc can optimize the global static variables
>> according to the C code, but it will skip assembly code -- it will pass
>> them to gas directly.
>>
>> if the static variable is used between C code and assembly code in one C
>> file (e.g. is_dyn_brkp in kgdb.c), it needs volatile to let gcc know it
>> should not be optimized, or it may cause issue.
> 
> In this case it's *mostly* a matter of taste but please avoid
> using volatile as a hammer when there are other tools available.
> 
>> -static unsigned char is_dyn_brkp = 0;
>> +static volatile unsigned char is_dyn_brkp;
> 
> Please instead use "__used", i.e.
> +static unsigned char __used is_dyn_brkp = 0;
> 

OK, thanks. I shall send patch v3 for it, next.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/