Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752885AbbHEQVM (ORCPT ); Wed, 5 Aug 2015 12:21:12 -0400 Received: from mga11.intel.com ([192.55.52.93]:59678 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379AbbHEQVK (ORCPT ); Wed, 5 Aug 2015 12:21:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,618,1432623600"; d="scan'208";a="778416322" Message-ID: <1438791519.17718.77.camel@spandruv-DESK3.jf.intel.com> Subject: Re: [PATCH] thermal: remove power allocator from list of default governors From: Srinivas Pandruvada To: Javi Merino Cc: Dmitry Torokhov , Eduardo Valentin , Zhang Rui , Tushar Dave , Lan Tianyu , Punit Agrawal , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Wed, 05 Aug 2015 09:18:39 -0700 In-Reply-To: <20150805083755.GC2688@e104805> References: <20150804163921.GA36852@dtor-ws> <20150805083755.GC2688@e104805> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2173 Lines: 57 On Wed, 2015-08-05 at 09:37 +0100, Javi Merino wrote: > On Tue, Aug 04, 2015 at 05:39:21PM +0100, Dmitry Torokhov wrote: > > As it currently stands the power allocator governor can not handle > > thermal zones that are not specifically crafted and therefore can not be > > used as a default governor. > > > > Users need to explicitly enable this governor for thermal zones that do > > have enough information for its operation. > > > > Signed-off-by: Dmitry Torokhov > > --- > > drivers/thermal/Kconfig | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index 0390044..34d05d3 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -82,14 +82,6 @@ config THERMAL_DEFAULT_GOV_USER_SPACE > > Select this if you want to let the user space manage the > > platform thermals. > > > > -config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR > > - bool "power_allocator" > > - select THERMAL_GOV_POWER_ALLOCATOR > > - help > > - Select this if you want to control temperature based on > > - system and device power allocation. This governor can only > > - operate on cooling devices that implement the power API. > > - > > Currently the only way we have for a thermal zone configured from > device tree to use a governor from the kernel boot is by using > THERMAL_DEFAULT_GOV_*. If we remove this option some devices won't > have a workable thermal framework until userspace is up and running. > > Would you rather have the power allocator governor accept every > thermal zone? May be allow to select when the binded cooling device can support this governor. Thanks, Srinivas > Cheers, > Javi > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/