Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753296AbbHERNF (ORCPT ); Wed, 5 Aug 2015 13:13:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47049 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752632AbbHERND (ORCPT ); Wed, 5 Aug 2015 13:13:03 -0400 Date: Wed, 5 Aug 2015 19:10:57 +0200 From: Oleg Nesterov To: Frederic Weisbecker Cc: LKML , Tejun Heo , Christoph Lameter , Rik van Riel , Andrew Morton Subject: Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3 Message-ID: <20150805171057.GA20238@redhat.com> References: <1438014440-20669-1-git-send-email-fweisbec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438014440-20669-1-git-send-email-fweisbec@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 895 Lines: 22 On 07/27, Frederic Weisbecker wrote: > > Hence those two debatable changes: > > _ We would like to use generic workqueues. System unbound workqueues are > a very good candidate but they are not wide affine, only node affine. > Now probably a node is enough to perform many parallel kmod jobs. > > _ We would like to remove the wait_for_helper kernel thread (UMH_WAIT_PROC > handler) to use the workqueue. It means that if the workqueue blocks, > and no other worker can take pending kmod request, we can be screwed. > Now if we have 512 threads, this should be enough. I think this series is fine. Feel free to add my reviewed-by. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/