Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753608AbbHERRA (ORCPT ); Wed, 5 Aug 2015 13:17:00 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:8701 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753559AbbHERQ5 convert rfc822-to-8bit (ORCPT ); Wed, 5 Aug 2015 13:16:57 -0400 Date: Wed, 5 Aug 2015 18:16:53 +0100 From: Liviu Dudau To: Stephen Hemminger Cc: Mirko Lindner , "ryan.harkin@linaro.org" , netdev , lkml Subject: Re: [PATCH] sky2: Add module parameter for passing the MAC address Message-ID: <20150805171652.GG20890@e106497-lin.cambridge.arm.com> References: <1438789854-29194-1-git-send-email-Liviu.Dudau@arm.com> <20150805094057.59260077@urahara> MIME-Version: 1.0 In-Reply-To: <20150805094057.59260077@urahara> User-Agent: Mutt/1.5.22 (2013-10-16) X-OriginalArrivalTime: 05 Aug 2015 17:16:53.0226 (UTC) FILETIME=[85EC6CA0:01D0CFA2] X-MC-Unique: XGgskW4cS6CxydHJEnuC9w-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1659 Lines: 48 On Wed, Aug 05, 2015 at 05:40:57PM +0100, Stephen Hemminger wrote: > On Wed, 5 Aug 2015 16:50:54 +0100 > Liviu Dudau wrote: > > > For designs where EEPROMs are not connected to PCI Yukon2 > > chips we need to get the MAC address from the firmware. > > Add a module parameter called 'mac_address' for this. It > > will be used if no DT node can be found and the B2_MAC > > register holds an invalid value. > > > > Signed-off-by: Liviu Dudau > > Yes, I can see that this can be a real problem, and other drivers > solve the problem. The standard method is to assign a random mac address > (and then let scripts overwrite) rather than introducing module parameter. > Module parameters are discouraged because they are device specific. > I agree. However, in my case, the boards people have assigned MAC addresses to the chip, they just didn't built the board in such a way as to allow one to store that MAC address in a permanent way :( And no, I can't use the DT because the chip is actually on the PCIe bus. Even with the generation of a random address, it still needs to be copied into the device, so I would guess that a version of the patch I've sent is still relevant? Best regards, Liviu > > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/