Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753733AbbHER0Z (ORCPT ); Wed, 5 Aug 2015 13:26:25 -0400 Received: from mail-by2on0090.outbound.protection.outlook.com ([207.46.100.90]:44772 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752744AbbHER0X (ORCPT ); Wed, 5 Aug 2015 13:26:23 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <55C24737.8000309@caviumnetworks.com> Date: Wed, 5 Aug 2015 10:26:15 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tomasz Nowicki CC: "Rafael J. Wysocki" , , , Len Brown , Robert Richter , David Daney Subject: Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call. References: <1438729319-9146-1-git-send-email-ddaney.cavm@gmail.com> <5621301.c1YGTkGNQk@vostro.rjw.lan> <55C212F6.40504@linaro.org> In-Reply-To: <55C212F6.40504@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: SN2PR07CA007.namprd07.prod.outlook.com (10.255.174.24) To CY1PR0701MB1728.namprd07.prod.outlook.com (25.163.21.142) X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1728;2:AZtTq+BGzZsBPr7QYOv/fTh11bfpPEgTuqe2OyAXZ1/sXBvlm7FBNNtl7QAO53+S+PWVQLx+8avWOTtsIaItY/AIXvJju/YvuywZ5Q1NEay55UrzJRi0uo/p9W3ypSt2f+dpHLOBcQMR7vFwQh6jlkeK7cxpx1iUM9780o61bBk=;3:kk45pRWXot7bDZ4JbAq4umAcFacZTEIJ9m/IV/8OqcH6uIIp7//QgJ0ZI9vZyYx0u3WEh7kiXf4sEDVppTQe0nZ76TMZqbuCsYPakoEQeoMZ90Xxb8ExiqoX1rKPbJlUs6sFzHX+EM6BVycZMVgq1A==;25:VGp+45oBs+yEt9GXqdIx99gM8WLt+Zz4unFg8Ge2EuKOqSyAbcETVcghLvTDV4FNGkhy6J/eRNkAb2k87NGo2YPdNcN7lBPmbgEXNnITS33zwLe2uglfbKA5o5GpLE8ua3Zpl8NqI2JV+HWynFCbQmI+UzBeYs7T6cgfFSI9mLn17G429UPIKpzsFNx6kDKPuWe+TCICh/F0AtlBiwFWWE6vZ6OiQQluCLCaxfE6e8yutTr1ZyBimrAbYxn00pT6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1728; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1728;20:ghKotuExcI5GkG900iwgRHhbvje71gUT6OM7CaZtVY4TdLLrxE30QVIZUoVBA99PmpmvX5TUmD0ZOs6gqb6MQnAi67gEv7yM4Vs9/RhAQYpy+32XHR51wfUPuYf+nirrXaiPX4teg1AN8wpsRhPmu8ahqU897mz16T/GgDsrDanTLyVdYILCOBLYHsAW9PLyMs+W90jkFg7RjK7ddho9hn0OnicNs1ymp1h4rAqhabA5y6hcs6na/fI9eW3qBmlUrNT34dupChVxGQ1FBWgYGMPQGiDCd7A3F6ruiVt1tRX7dY1QAcyiBUZSgNj3CZJ9UfYcy/dTW03fjtx7gqlnniYNCzap/vrBoMJ5e/jDUsi3B9Z2AXRTGLkyu7aqxyxz8Mds749U7ZEi85v/R/uI0UDmOoUbxQlCsjoKUva/ajgoGhpm/LKLqvNg3nIsu48y4HUQRme/exJ3KUGee00l7W0rgeowR5iZtFV0sx0U71TsHPnF8ysE1ngJkIthAgxGRkjwgdjMkhS41ZUwCL7V/wHRvFQguIV+TtEcb1yra9C0Ql34AWqTJk4OIJg24Fcvy0IRkcsixfetsehUcVIJnSX07OVYCdNk0cuyTha62Sw=;4:gQAjBy1NoWUTruJrRW6EQO7F8Z1xe0KqWuntwYpowq0p7XSXlDNXj+qRU9/RJrOIQ4tgHrPRg/Ktp7NHrwQlSSYvBrs8QPQDiOKTp8SjKgbOJjcJPxAiZipt0riwrS0upEmGwvYyp1TO6w1YNmpVTnfKeM9BN+vlYXbMVqK0eEksaqYoUx/KsOFMvxv0F1U7+Ck1FzzrcRXVA4Kbbg06n5QCRmnqnyharO8v2Lh0h/5Ngeql66SnjvNMdYBtd6fa+yHL01jRxBBS/KirKbTf4EzUQZ0fbQdVQu3glwtwGRo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:CY1PR0701MB1728;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1728; X-Forefront-PRVS: 06592CCE58 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(199003)(24454002)(189002)(377454003)(43784003)(479174004)(92566002)(65956001)(23676002)(59896002)(46102003)(4001540100001)(189998001)(64126003)(33656002)(42186005)(80316001)(77096005)(50466002)(87976001)(68736005)(36756003)(101416001)(40100003)(76176999)(77156002)(106356001)(47776003)(65816999)(110136002)(97736004)(2950100001)(66066001)(5001960100002)(54356999)(64706001)(5001830100001)(19580405001)(19580395003)(81156007)(122386002)(87266999)(105586002)(5001860100001)(69596002)(50986999)(83506001)(65806001)(53416004)(62966003)(4001350100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0701MB1728;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjA3MDFNQjE3Mjg7MjM6NWM3OXRzL2tWcUwxOHcrZEh5SmMzcS9t?= =?utf-8?B?Vi9MNnpIdWltUkpEb2prY01kWXNXL09DRGJJaEt4VEZlS2Y2elJiejRaaE1X?= =?utf-8?B?V3NSWEI3ZmVtN3dzQXZFM29HS1c5bGc5ZWJNQ3dCblJEa3pvUlV5WERpdWJJ?= =?utf-8?B?aWRlK1FKZGxPVlV4WnowSVVNM3VNUGpRc2IzQ3JURjg4NHZWb1M1MC8zU3pI?= =?utf-8?B?S0dOaWtpTXBxSVNUZ2hBdFpaS2p5UVBIWGJOb3dzZUxzUU1zby9HanhuQWxS?= =?utf-8?B?M2tFRnVkQnRUWXhvWm11bEVBSlBZSGo4bjQ0N1ZpcnhhNjhFWWtYckE4QUM5?= =?utf-8?B?TUtNVlI3QnFtUzJnMVRITlRGRGkxbVpvcUVKTnRZeDVuaFk3aWJ3ME5FRlgz?= =?utf-8?B?VC9TQ0RRcE5TQVQxVURiczBxT3huZzNtMVM4SlU2WWRYVFlQZ04xcFZaQyt4?= =?utf-8?B?Wm8yTWFkZEJIUGZhd3RncmtuTU1hUjI4djhQQUNkRkEzU2w3SFM3d0xIaGUy?= =?utf-8?B?cUFlOGJjS0RJQXdsL3FDM3RqbE5Xd1dSUExvYWtYWjF1dzVWcWhkWnhmVDlw?= =?utf-8?B?TXA4M0RZTWdEMFhhNjFZVUlseENkck92dFV4ZHMzTm51aTBnRllzWERVTmhl?= =?utf-8?B?Yy9lVjZKT2JJVVJFdyttVmxPbk5pTkhNQlBLOWZkSFdhaFVydHZjYUNFT0Rw?= =?utf-8?B?ZFV0bmJFTnZ2c3kvbFJ2Wm9KMlE2ZFJiT05GWWk0TXAwYnZUWDFoRVNjZ1kv?= =?utf-8?B?cy9mMVg1YnoyOVJldnFRaWNtUlFnYjRORUJUaFl0NlU1Y3BLYWE5aitIK05m?= =?utf-8?B?OTQ1ejNqdXdMZUZhOFkwcUxja0JrdWhWRmlHZUZYa3J0NVFGWWxTcFlYK2t5?= =?utf-8?B?SWEwTXU4cnFIRGRUeXA3Tjk0VTFLQU1nRndIOERseEZTS3VGVjVncWtJNFUz?= =?utf-8?B?L1ZmbERPTXd5YXZERkhHMC9lK2p4S3J1QVhMdUhRUW8rb0xENlBDVCt0Misr?= =?utf-8?B?blhRTElhL1V0MmhyMTRySGpyb0tUcnV3UlN4OVNpTkZ5dExVK2k5aUo0aURY?= =?utf-8?B?dGVOS1lVMzJma3NYcDNZUjFrMDlDcDY0d3Bzemc4RG5iaUkvUXVOUk5RNTR1?= =?utf-8?B?c3pBV1Q0cHRRYm5xTW5RenE5U2o4b1F6YUs2SjZZL3RzSDJzOWxIaHAwTHJi?= =?utf-8?B?ZURtME84VjRHTENCQzZDWnY5MUtzT0pid1ZEbTdibTBxditBUk1SRHU0RzNj?= =?utf-8?B?UTllYkVWLzlsanBRQTR3QWYrZE5KMXB0cjFsQ3BRek9yS1BPam9xYlp4MDBU?= =?utf-8?B?eEVSN1dHZzkxVktQdC9DQzIzZEtXbitVUFJKeFRJTmVHc2RWbGVTVjVVR3Iy?= =?utf-8?B?S0VBWU1UZ2NxVEVodkRGcU5LZWkvZFEvU3JSeSttVFhFckRRN3E0TUt4aGdp?= =?utf-8?B?OCt1RFRuUStndTNoY1ZvZHFZejZJeElFMzgzR0U1TUJ4Y3krZ08vUm05WGRV?= =?utf-8?B?SDNTbkY5eVhraUpoWWlDQVg3ay95VHhhakNZRlVKUEo1dk1oTXhwZlNRcHJv?= =?utf-8?B?UEdwdGIyRjBmZ2gxYzJpVG9ESnRJS2ZjZnpNU1JoaUNJTnRTeHBPQ1BJNHFj?= =?utf-8?B?dEFXWGR2ZnJqb2U3VWVPSUdmbE1BR0YzTktFbkpyTSt1elJVYUpGUmpnTGxY?= =?utf-8?B?MDdtaHh5Z3Nrckx4YSs1ZVJqa2lDbnVteWR1bjRZbVU4OVAzMWd2VUwzL01K?= =?utf-8?B?K1d6SW9BQzJWUGFvRTdoSTRyd3h1YXpNcHQ5Q1ZOVWRhb3IwT2dIL29kMko4?= =?utf-8?Q?EidMKwU6z0pJydg?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1728;5:9xTb+ut7LGBzd9MqHcBaOLMvQM8z/ewyA9jMbYdXoU022OIOLHF/LhHTd+LicjPPSp43BREZgKvnXfL3tNmaVD6yZ0c1LtDg/pTu3SxWNqMwnUv0OzQcIEQMVZU0k8ewvN26tJFK8jJ5xXE6fKpdfg==;24:4LuSe4Us0D0CqLC9ljUmeMHMzLza6H8mbTs3ISnsULldagBM5fRyFzNNcD+J0RBh5NY2+1ZI4AN0AaZtcbBIdP9GrwomKGTcVdduhfIHWjM=;20:wWeAli/UFrN0DOuRVuaAY4i3fOiA0P3GgsLUJJrf+Gz+AtQPMGsV9VCf33tkTmkXJUXXoeaOVNoyAl1HackRIw== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2015 17:26:19.8498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1728 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1355 Lines: 37 On 08/05/2015 06:43 AM, Tomasz Nowicki wrote: > On 05.08.2015 15:48, Rafael J. Wysocki wrote: >> On Tuesday, August 04, 2015 04:01:59 PM David Daney wrote: >>> From: Tomasz Nowicki >>> >>> Fixes the following build error when building drivers as modules: >>> >>> ERROR: "acpi_dev_prop_read_single" [drivers/net/phy/mdio-octeon.ko] >>> undefined! >>> ERROR: "acpi_dev_prop_read_single" >>> [drivers/net/ethernet/cavium/thunder/thunder_bgx.ko] undefined! >> >> Can you please tell me why the drivers in question use that function >> directly, although they aren't supposed to? >> >> Clearly, their authors had not tried to build them as modules or they >> would have noticed the problem at the development stage already. >> >> What would be wrong with using the generic device properties API instead? >> > Yes, you are right. We should use: > int device_property_read_u64_array(struct device *dev, const char > *propname, u64 *val, size_t nval); > Thanks all, for the review and suggestions. We we try the suggested approach and see how it goes... Thanks again, David Daney -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/