Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbbHER3W (ORCPT ); Wed, 5 Aug 2015 13:29:22 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:36660 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751912AbbHER3V (ORCPT ); Wed, 5 Aug 2015 13:29:21 -0400 Date: Wed, 5 Aug 2015 18:29:03 +0100 From: Javi Merino To: Eduardo Valentin , Dmitry Torokhov Cc: Zhang Rui , Lukasz Majewski , Peter Feuerer , Sascha Hauer , Punit Agrawal , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] thermal: power_allocator: do not use devm* interfaces Message-ID: <20150805172902.GE2688@e104805> References: <20150804163340.GA33245@dtor-ws> <20150805082910.GB2688@e104805> <20150805165020.GB3603@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150805165020.GB3603@dtor-ws> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 29 On Wed, Aug 05, 2015 at 05:50:20PM +0100, Dmitry Torokhov wrote: > On Wed, Aug 05, 2015 at 09:29:11AM +0100, Javi Merino wrote: > > On Tue, Aug 04, 2015 at 05:33:40PM +0100, Dmitry Torokhov wrote: > > > The code in question is called outside of standard driver > > > probe()/remove() callbacks and thus will not benefit from use of devm* > > > infrastructure. > > > > > > Signed-off-by: Dmitry Torokhov > > > > We added the devm* calls because Eduardo asked for them in the review. > > I don't have a strong opinion regarding this, I'll leave the decision > > to Eduardo. > > I tried to look for his reasons, if any, but even in earliest posted > versions use devm* for allocating memory http://thread.gmane.org/gmane.linux.power-management.general/45000/focus=45265 http://thread.gmane.org/gmane.linux.power-management.general/46064/focus=1722858 He didn't give reasons and I didn't ask for them. He insisted on it so I just added it across the board. Cheers, Javi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/