Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141AbbHEUXN (ORCPT ); Wed, 5 Aug 2015 16:23:13 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:34969 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbbHEUXL (ORCPT ); Wed, 5 Aug 2015 16:23:11 -0400 MIME-Version: 1.0 X-Originating-IP: [73.143.245.155] In-Reply-To: <20150805193838.GK32407@madcap2.tricolour.ca> References: <20150805193838.GK32407@madcap2.tricolour.ca> Date: Wed, 5 Aug 2015 16:23:10 -0400 Message-ID: Subject: Re: [PATCH V4 (was V6)] audit: use macros for unset inode and device values From: Paul Moore To: Richard Guy Briggs Cc: William Roberts , linux-audit@redhat.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1513 Lines: 40 On Wed, Aug 5, 2015 at 3:38 PM, Richard Guy Briggs wrote: > On 15/08/05, William Roberts wrote: >> On Aug 1, 2015 12:44 PM, "Richard Guy Briggs" wrote: >> > >> > Signed-off-by: Richard Guy Briggs >> > --- >> > include/uapi/linux/audit.h | 2 ++ >> > kernel/audit.c | 2 +- >> > kernel/audit_watch.c | 8 ++++---- >> > kernel/auditsc.c | 6 +++--- >> > 4 files changed, 10 insertions(+), 8 deletions(-) >> > >> > diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h >> > index d3475e1..971df22 100644 >> > --- a/include/uapi/linux/audit.h >> > +++ b/include/uapi/linux/audit.h >> > @@ -440,6 +440,8 @@ struct audit_tty_status { >> > }; >> > >> > #define AUDIT_UID_UNSET (unsigned int)-1 >> > +#define AUDIT_INO_UNSET (unsigned long)-1 >> > +#define AUDIT_DEV_UNSET (unsigned)-1 >> >> Why unsigned int in one but unsigned in the other? > > It was based on one of the instances it was originally replacing (I > can't find it now). It could be dev_t if it was moved out of uapi as > Paul preferred, but I prefer unsigned int now that you point it out. Once we move it out of the uapi header it should probably be (dev_t)-1. -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/