Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755210AbbHEWHE (ORCPT ); Wed, 5 Aug 2015 18:07:04 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39236 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754092AbbHEWHB (ORCPT ); Wed, 5 Aug 2015 18:07:01 -0400 Date: Wed, 5 Aug 2015 15:06:59 -0700 From: Andrew Morton To: Dan Streetman Cc: Seth Jennings , Linux-MM , linux-kernel Subject: Re: [PATCH 1/3] zpool: add zpool_has_pool() Message-Id: <20150805150659.eefc5ff531741ab34f48b330@linux-foundation.org> In-Reply-To: References: <1438782403-29496-1-git-send-email-ddstreet@ieee.org> <1438782403-29496-2-git-send-email-ddstreet@ieee.org> <20150805130836.16c42cd0a9fe6f4050cf0620@linux-foundation.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 21 On Wed, 5 Aug 2015 18:00:26 -0400 Dan Streetman wrote: > > > > If there's some reason why this can't happen, can we please have a code > > comment which reveals that reason? > > zpool_create_pool() should work if this returns true, unless as you > say the module is rmmod'ed *and* removed from the system - since > zpool_create_pool() will call request_module() just as this function > does. I can add a comment explaining that. I like comments ;) Seth, I'm planning on sitting on these patches until you've had a chance to review them. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/