Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932119AbbHEXQE (ORCPT ); Wed, 5 Aug 2015 19:16:04 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35344 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754156AbbHEXQC (ORCPT ); Wed, 5 Aug 2015 19:16:02 -0400 Date: Wed, 5 Aug 2015 16:16:10 -0700 From: Stephen Hemminger To: Francois Romieu Cc: Liviu Dudau , Mirko Lindner , "ryan.harkin@linaro.org" , netdev , lkml Subject: Re: [PATCH] sky2: Add module parameter for passing the MAC address Message-ID: <20150805161610.3bcdde98@urahara> In-Reply-To: <20150805203342.GA26748@electric-eye.fr.zoreil.com> References: <1438789854-29194-1-git-send-email-Liviu.Dudau@arm.com> <20150805094057.59260077@urahara> <20150805171652.GG20890@e106497-lin.cambridge.arm.com> <20150805203342.GA26748@electric-eye.fr.zoreil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1253 Lines: 36 Something like this: Subject: [PATCH net-next] sky2: use random address if EEPROM is bad On some embedded systems the EEPROM does not contain a valid MAC address. In that case it is better to fallback to a generated mac address and let init scripts fix the value later. Reported-by: Liviu Dudau Signed-off-by: Stephen Hemminger --- a/drivers/net/ethernet/marvell/sky2.c 2015-05-21 15:13:03.621126050 -0700 +++ b/drivers/net/ethernet/marvell/sky2.c 2015-08-05 16:12:38.734534467 -0700 @@ -4819,6 +4819,16 @@ static struct net_device *sky2_init_netd memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port * 8, ETH_ALEN); + /* if the address is invalid, use a random value */ + if (!is_valid_ether_addr(dev->dev_addr)) { + struct sockaddr sa = { AF_UNSPEC }; + + netdev_warn(dev, + "Invalid MAC address defaulting to random\n"); + sky2_set_mac_address(dev, &sa); + dev->addr_assign_type |= NET_ADDR_RANDOM; + } + return dev; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/