Message-ID: <55C2A38F.6000708@caviumnetworks.com>
Date: Wed, 5 Aug 2015 17:00:15 -0700
From: David Daney <ddaney@caviumnetworks.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
CC: <daniel.sanders@imgtec.com>, <linux-mips@linux-mips.org>,
        <cernekee@gmail.com>, <Zubair.Kakakhel@imgtec.com>,
        <geert+renesas@glider.be>, <david.daney@cavium.com>,
        <peterz@infradead.org>, <heiko.carstens@de.ibm.com>,
        <paul.gortmaker@windriver.com>, <behanw@converseincode.com>,
        <macro@linux-mips.org>, <cl@linux.com>, <pkarat@mvista.com>,
        <linux@roeck-us.net>, <tkhai@yandex.ru>, <james.hogan@imgtec.com>,
        <alexinbeijing@gmail.com>, <rusty@rustcorp.com.au>,
        <Steven.Hill@imgtec.com>, <lars.persson@axis.com>,
        <aleksey.makarov@auriga.com>, <paul.burton@imgtec.com>,
        <linux-kernel@vger.kernel.org>, <ralf@linux-mips.org>,
        <luto@amacapital.net>, <dahi@linux.vnet.ibm.com>,
        <markos.chandras@imgtec.com>, <eunb.song@samsung.com>,
        <kumba@gentoo.org>
Subject: Re: [PATCH v4 0/3] MIPS executable stack protection
References: <20150805234348.20722.71740.stgit@ubuntu-yegoshin>
In-Reply-To: <20150805234348.20722.71740.stgit@ubuntu-yegoshin>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2015 00:00:20.0820 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1722
X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1658;2:3B16xQMceFq+tDBD4/oKSUZcqYpMFLyU/oq7fTHGnxf3wgvjq32YA+ONd/hEM1pecmY6ULIQRCYK2LFbqnszgSuP0rbMcnPQXWZp78QIl1iaPrmSw3FV/aVnjgmfXBd1x829yumV7JUwciR9Ze0fb2g5ALnN6FDLi4zDQicCsvQ=;3:vG5E0bi0ajlZMPVDhkS+RyxCMs1as8xLClxULlWVYI5ELqpVnrxQvI1DcGN7eu8xhcUKjXx64OITiX99m4CUu3m9yuVIbiKgD0Oasj8H+07NJckY5jIx/BsrV31zUZwblIVs/6dMePmGYEgBvSGGFg==;25:SJkQrGLfZ2ltBCBekA+rSrDxaLaBoa1kQ+SMXQnbu0ii27mZPVo/d1usyjgeAPXM0QjH3h6cwH/W98nb0R54OQrMiZDld0PRoXrKy0Fn0aYSrLbCDI9N/aJdymkoWzaoUhUZLgqVzLoSYhq86JRGBhomfjQcIJfnXvdbhzTTXXBNq6lpbTV/Y8jUnWUkPOVWrGd2GfvgAWxdivcKLVWD6d0T4MiS9eQDc9ujcprOaniymAkCsSp+5tOHq5dfbG7zmP5gvNyKuuv9LiOph482gg==;23:pWFcsS84anxCu1vS1ur0eiCfQ/txRSGXE1VwcX6WcXrIbN6egDp/0tXXWvr11coXo4l54vTWGRq3vyqU+IJdCdJOjcRZMHssaam970ZrXvxoeXyu876z+WJaRlulVRtFjjnqW1+jwDcR0gSbb4ruGHKKB9GmqaLLsi55RqDUSg2KpEZTbj2amXv8LW0rrkP0UHdnzvk3/e6ka3pEqPMRCyolLeN4b6xoAOB1BiOIO3uRlXUknWbCoW3nsydGDO4K
X-OriginatorOrg: caviumnetworks.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3502
Lines: 90

On 08/05/2015 04:49 PM, Leonid Yegoshin wrote:
> The following series implements an executable stack protection in MIPS.
>
> It sets up a per-thread 'VDSO' page and appropriate TLB support.
> Page is set write-protected from user and is maintained via kernel VA.
> MIPS FPU emulation is shifted to new page and stack is relieved for
> execute protection as is as all data pages in default setup during ELF
> binary initialization.

Does it handle nested emulation?

   1) Emulation started on instruction in main program flow, we are 
about to re-enter user space..


   2) Asynchronous signal is received.


   3) Return to user space.  Where do we go?  Is it the signal handler 
or the instruction emulation?

If we go to the signal handler and it needs emulation, what happens?

David Daney


> The real protection is controlled by GLIBC and
> it can do stack protected now as it is done in other architectures and
> I learned today that GLIBC team is ready for this.
>
> Note: actual execute-protection depends from HW capability, of course.
>
> This patch is required for MIPS32/64 R2 emulation on MIPS R6 architecture.
> Without it 'ssh-keygen' crashes pretty fast on attempt to execute instruction
> in stack.
>
> v2 changes:
>      - Added an optimization during mmap switch - doesn't switch if the same
>        thread is rescheduled and other threads don't intervene (Peter Zijlstra)
>      - Fixed uMIPS support (Paul Burton)
>      - Added unwinding of VDSO emulation stack at signal handler invocation,
>        hiding an emulation page (Andy Lutomirski note in other patch comments)
>
> V3 change: heavy preemption friendly.
>
> V4 changes:
>      - Fixed bug in supplementary TLB flush (change KVA to user address space)
>      - Rebased to 4.X kernel
> ---
>
> Leonid Yegoshin (3):
>        MIPS: mips_flush_cache_range is added
>        MIPS: Setup an instruction emulation in VDSO protected page instead of user stack
>        MIPS: set stack/data protection as non-executable
>
>
>   arch/mips/include/asm/cacheflush.h    |    3 +
>   arch/mips/include/asm/fpu_emulator.h  |    2
>   arch/mips/include/asm/mmu.h           |    3 +
>   arch/mips/include/asm/page.h          |    2
>   arch/mips/include/asm/processor.h     |    2
>   arch/mips/include/asm/switch_to.h     |   14 +++
>   arch/mips/include/asm/thread_info.h   |    3 +
>   arch/mips/include/asm/tlbmisc.h       |    1
>   arch/mips/include/asm/vdso.h          |    3 +
>   arch/mips/kernel/mips-r2-to-r6-emul.c |   10 +-
>   arch/mips/kernel/process.c            |    7 ++
>   arch/mips/kernel/signal.c             |    4 +
>   arch/mips/kernel/vdso.c               |   44 +++++++++
>   arch/mips/math-emu/cp1emu.c           |    8 +-
>   arch/mips/math-emu/dsemul.c           |  154 +++++++++++++++++++++++++++------
>   arch/mips/mm/c-octeon.c               |    8 ++
>   arch/mips/mm/c-r3k.c                  |    8 ++
>   arch/mips/mm/c-r4k.c                  |   43 +++++++++
>   arch/mips/mm/c-tx39.c                 |    9 ++
>   arch/mips/mm/cache.c                  |    4 +
>   arch/mips/mm/fault.c                  |    5 +
>   arch/mips/mm/tlb-r4k.c                |   42 +++++++++
>   22 files changed, 343 insertions(+), 36 deletions(-)
>
> --
> Signature
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/