Message-ID: <55C2AC5B.50408@caviumnetworks.com>
Date: Wed, 5 Aug 2015 17:37:47 -0700
From: David Daney <ddaney@caviumnetworks.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
CC: Paul Burton <paul.burton@imgtec.com>, <daniel.sanders@imgtec.com>,
        <linux-mips@linux-mips.org>, <cernekee@gmail.com>,
        <Zubair.Kakakhel@imgtec.com>, <geert+renesas@glider.be>,
        <david.daney@cavium.com>, <peterz@infradead.org>,
        <heiko.carstens@de.ibm.com>, <paul.gortmaker@windriver.com>,
        <behanw@converseincode.com>, <macro@linux-mips.org>, <cl@linux.com>,
        <pkarat@mvista.com>, <linux@roeck-us.net>, <tkhai@yandex.ru>,
        <james.hogan@imgtec.com>, <alexinbeijing@gmail.com>,
        <rusty@rustcorp.com.au>, <Steven.Hill@imgtec.com>,
        <lars.persson@axis.com>, <aleksey.makarov@auriga.com>,
        <linux-kernel@vger.kernel.org>, <ralf@linux-mips.org>,
        <luto@amacapital.net>, <dahi@linux.vnet.ibm.com>,
        <markos.chandras@imgtec.com>, <eunb.song@samsung.com>,
        <kumba@gentoo.org>
Subject: Re: [PATCH v4 3/3] MIPS: set stack/data protection as non-executable
References: <20150805234348.20722.71740.stgit@ubuntu-yegoshin> <20150805234936.20722.60927.stgit@ubuntu-yegoshin> <20150805235543.GG2057@NP-P-BURTON> <55C2A50A.50805@imgtec.com> <55C2A6FE.1020003@caviumnetworks.com> <55C2A91B.1090704@imgtec.com>
In-Reply-To: <55C2A91B.1090704@imgtec.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2015 00:37:50.9216 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1719
X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1345;2:/p4IHWuSCJ9NfWMaOXefIEern5pDl4Df/Lfc7Amo7CUedSmDBjg3F+hCYBGLkFkFDR71tgu2aTl6NoG1CaZ3pgC8eabIbpPXc8nMxaP+bGfV0TrCwLij52Cfk/lhrI58RzTjEGx3T4SBKWOnBBUZt/yed16zFOTH3b4h6XokfVw=;3:2ElUasHKwNXm/SZhmHpYbTytAajDdjtYJ9qCNoWz3lK4T83bonBVG1ukwnf7hPIArOGZCdQq9d6UP8cYj9OnGyeLVbAp8jdkowHvZbtaAQRa2hwuCMXDa6ztYZ0hqPIR+0sYut+h9z8kM4O5CYAQzQ==;25:aVt5u1KfntgHEWGB3iuqs5nNPaS8XjQzQsmOHq8rutAZpx8RN9eFTzSpAa5Ty0KjsRk+O1ulsPOPvJ9uNatAmA9C+Xi2l7154eDJk54pCmdUS7kk8TK8vG15V/RmYdQR9nEQ36ECwhO4mdyCTErU3PhDg9joyxY0n/GDMjrq99Dwt1zk+mtwHLAg4XIT/Do/Ct2QUsjBzEYax6MiTNcBRUPwi4T57LTy4f2NE6gVwYdFvU4eRG2bu+OP6IdY+YQePEkjh7Ei1E/B2jPFgYbkdg==;23:cCrGE9kGTNXc9Yb5/Lp6xxPCh7Cq55Zwshlk1SvenE1mzx20I4Ta2+XrW5lIi+8GPx9K/Dmo6JHB15v4rT1UR6bIATLoUZKnP5tCLvKPy9MRQkv3S7xppyd+MSo7rqNwTyz4PeyWXFpb10BFXTYtj+IUucq5T7RcqUa4mx9LFTJdj4KFkzIaAVbAc5vH4pNdPTyA0/aV9Pre89/c5AfLfaT+gefGrcw6/PwzUEtlWvVbyiNP9/HzzpEVyQ+j8+7x
X-OriginatorOrg: caviumnetworks.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1766
Lines: 48

On 08/05/2015 05:23 PM, Leonid Yegoshin wrote:
> On 08/05/2015 05:14 PM, David Daney wrote:
>> On 08/05/2015 05:06 PM, Leonid Yegoshin wrote:
>>> On 08/05/2015 04:55 PM, Paul Burton wrote:
>>>>
>>>>
>>>> As was pointed out last time you posted this, it breaks backwards
>>>> compatibility with userland & thus cannot be applied.
>>>
>>> Never observed since first version.
>>>
>>> In other side, the problem with apps like ssh_keygen is observed in
>>> absence of executable stack protection.
>>
>> You cannot change the default.
>>
>> If your ssh_keygen is broken, get a working version.
>
> It is actually any application which requests non-executable stack
> protection and needs some emulation BEFORE GLIBC cancels that
> non-executable stack protection due to libraries.
>
> If you build all libraries with PT_GNU_STACK 'non-executable' and use
> application with the same protection then you can't emulate even a
> single instruction - it crashes immediately. So, it is not a bad
> application, it is a bad choice for emulation space in past.
>

This just means that your userspace is broken.

If GLibC cannot do the right thing then it should be fixed.

The very first thing that is executed is ld.so, you need to make your 
ld.so do the right thing before transferring control to your program's 
entry point.

You cannot change the default setting for executable stack just because 
you have created a broken userspace.

The ability of legacy userspace to continue functioning cannot be 
sacrificed.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/