Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754444AbbHFC7J (ORCPT ); Wed, 5 Aug 2015 22:59:09 -0400 Received: from mga02.intel.com ([134.134.136.20]:31213 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754407AbbHFC7I (ORCPT ); Wed, 5 Aug 2015 22:59:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,622,1432623600"; d="scan'208";a="743147787" Subject: Re: [PATCH v2 8/9] KVM: MMU: fully check zero bits for sptes To: Paolo Bonzini References: <1438747467-25425-1-git-send-email-guangrong.xiao@linux.intel.com> <1438747467-25425-9-git-send-email-guangrong.xiao@linux.intel.com> <55C1E1A3.4020300@redhat.com> Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, ru.pchel@gmail.com From: Xiao Guangrong Message-ID: <55C2CC29.30402@linux.intel.com> Date: Thu, 6 Aug 2015 10:53:29 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55C1E1A3.4020300@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 32 On 08/05/2015 06:12 PM, Paolo Bonzini wrote: > > > On 05/08/2015 06:04, Xiao Guangrong wrote: >> - for_each_shadow_entry_lockless(vcpu, addr, iterator, spte) >> + for_each_shadow_entry_lockless(vcpu, addr, iterator, spte) { >> + leaf = iterator.level; >> + >> + if (!root) >> + root = leaf; >> + >> + sptes[leaf - 1] = spte; >> + > > I'm a bit undecided between this and open-coding the macro: > > for (shadow_walk_init(&iterator, vcpu, addr), root = iterator.level; > shadow_walk_okay(&iterator); > __shadow_walk_next(&iterator, spte)) { > leaf = iterator.level; > spte = mmu_spte_get_lockless(iterator.sptep); > > Any second opinions? Your adjustment is good to me, i do not have other ideas... :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/