Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754213AbbHFDkj (ORCPT ); Wed, 5 Aug 2015 23:40:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40648 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbbHFDki (ORCPT ); Wed, 5 Aug 2015 23:40:38 -0400 Date: Wed, 5 Aug 2015 23:40:34 -0400 From: Richard Guy Briggs To: Paul Moore Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, sgrubb@redhat.com, eparis@redhat.com Subject: Re: [PATCH V5] audit: use macros for unset inode and device values Message-ID: <20150806034034.GA18741@madcap2.tricolour.ca> References: <4dbec928da0490e35bee7388e698845e70caa9ed.1438805802.git.rgb@redhat.com> <6956887.xCl3Q82COv@sifl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6956887.xCl3Q82COv@sifl> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1974 Lines: 51 On 15/08/05, Paul Moore wrote: > On Wednesday, August 05, 2015 04:19:09 PM Richard Guy Briggs wrote: > > Clean up a number of places were casted magic numbers are used to represent > > unset inode and device numbers in preparation for the audit by executable > > path patch set. > > > > Signed-off-by: Richard Guy Briggs > > --- > > v5: Move macros from include/uapi/linux/audit.h to include/linux/audit.h > > Use "unsigned int" rather than bare "unsigned". > > > > include/linux/audit.h | 3 +++ > > kernel/audit.c | 2 +- > > kernel/audit_watch.c | 8 ++++---- > > kernel/auditsc.c | 6 +++--- > > 4 files changed, 11 insertions(+), 8 deletions(-) > > > > diff --git a/include/linux/audit.h b/include/linux/audit.h > > index c2e7e3a..48ae90c 100644 > > --- a/include/linux/audit.h > > +++ b/include/linux/audit.h > > @@ -27,6 +27,9 @@ > > #include > > #include > > > > +#define AUDIT_INO_UNSET (unsigned long)-1 > > +#define AUDIT_DEV_UNSET (unsigned int)-1 > > I suspect it was lost in the noise when I mentioned it on v4, but how about > changing AUDIT_DEV_UNSET to "(dev_t)-1"? I saw your comment only after resubmitting. I'm fine either way. If it is needed for uapi later it can be changed then. Is it easy to change in your workflow, or should I resubmit? I know you routinely change the patch description, but could not remember if you have actually changed the patch itself... > paul moore - RGB -- Richard Guy Briggs Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/