Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753950AbbHFGQ0 (ORCPT ); Thu, 6 Aug 2015 02:16:26 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:45775 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbbHFGQZ (ORCPT ); Thu, 6 Aug 2015 02:16:25 -0400 X-IronPort-AV: E=Sophos;i="5.15,622,1432591200"; d="scan'208";a="142145476" Date: Thu, 6 Aug 2015 08:16:21 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Sergey Senozhatsky cc: Brian Norris , Salah Triki , dwmw2@infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] jffs2: Remove NULL checks from jffs2_destroy_slab_caches In-Reply-To: <20150805133247.GB576@swordfish> Message-ID: References: <1438717590-4263-1-git-send-email-salah.triki@acm.org> <20150804200639.GP10676@google.com> <20150805133247.GB576@swordfish> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3831 Lines: 110 On Wed, 5 Aug 2015, Sergey Senozhatsky wrote: > > Hi, > > Cc Julia Lawall > > On (08/04/15 13:06), Brian Norris wrote: > > On Tue, Aug 04, 2015 at 08:46:30PM +0100, Salah Triki wrote: > > > kmem_cache_destroy can be called with NULL values. Thus, the checks that > > > precede the calls are useless. > > > > This isn't *currently* true. Only after a bit of work did I find that > > this is queued to change in the next release -- akpm has a patch: > > > > commit 3e54c0cd3abdca0cf91854278c8633fc7df6beb1 > > Author: Sergey Senozhatsky > > Date: Thu Jul 30 09:55:36 2015 +1000 > > > > mm/slab_common: allow NULL cache pointer in kmem_cache_destroy() > > > > Please provide the appropriate context next time. And for the moment, I will > > not apply this, because this does not work on the current MTD development tree. > > Try your patch bomb on the next release, as it's not worth my time to > > cross-merge a -next branch just for a "cleanup". > > > > Julia already has a patch set to cleanup all the existing users > (not published yet, though). > > Apart from that, and this is more important, the patch in question > looks to me as 100% copy paste of a patch by Julia Lawall. > > https://lkml.org/lkml/2015/6/10/31 > > And no, Salah, it's not "Signed-off-by: Salah Triki ". > > For the record, this is the second, let's say strange, patch from Salah > that I see today. I'm missing some context. As far as I can see, kmem_cache_destroy is updated in linux-next. So it seems like it could be OK to submit a patch to clean up the uses now. Does Salah's patch address all three functions: kmem_cache_destroy, mempool_destroy, and dma_pool_destroy? julia > > -ss > > > > Signed-off-by: Salah Triki > > > --- > > > fs/jffs2/malloc.c | 27 +++++++++------------------ > > > 1 file changed, 9 insertions(+), 18 deletions(-) > > > > > > diff --git a/fs/jffs2/malloc.c b/fs/jffs2/malloc.c > > > index b8fd651..ce11897 100644 > > > --- a/fs/jffs2/malloc.c > > > +++ b/fs/jffs2/malloc.c > > > @@ -97,25 +97,16 @@ int __init jffs2_create_slab_caches(void) > > > > > > void jffs2_destroy_slab_caches(void) > > > { > > > - if(full_dnode_slab) > > > - kmem_cache_destroy(full_dnode_slab); > > > - if(raw_dirent_slab) > > > - kmem_cache_destroy(raw_dirent_slab); > > > - if(raw_inode_slab) > > > - kmem_cache_destroy(raw_inode_slab); > > > - if(tmp_dnode_info_slab) > > > - kmem_cache_destroy(tmp_dnode_info_slab); > > > - if(raw_node_ref_slab) > > > - kmem_cache_destroy(raw_node_ref_slab); > > > - if(node_frag_slab) > > > - kmem_cache_destroy(node_frag_slab); > > > - if(inode_cache_slab) > > > - kmem_cache_destroy(inode_cache_slab); > > > + kmem_cache_destroy(full_dnode_slab); > > > + kmem_cache_destroy(raw_dirent_slab); > > > + kmem_cache_destroy(raw_inode_slab); > > > + kmem_cache_destroy(tmp_dnode_info_slab); > > > + kmem_cache_destroy(raw_node_ref_slab); > > > + kmem_cache_destroy(node_frag_slab); > > > + kmem_cache_destroy(inode_cache_slab); > > > #ifdef CONFIG_JFFS2_FS_XATTR > > > - if (xattr_datum_cache) > > > - kmem_cache_destroy(xattr_datum_cache); > > > - if (xattr_ref_cache) > > > - kmem_cache_destroy(xattr_ref_cache); > > > + kmem_cache_destroy(xattr_datum_cache); > > > + kmem_cache_destroy(xattr_ref_cache); > > > #endif > > > } > > > > > > -- > > > 1.9.1 > > > > > > > > > ______________________________________________________ > > > Linux MTD discussion mailing list > > > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/