Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754581AbbHFG2h (ORCPT ); Thu, 6 Aug 2015 02:28:37 -0400 Received: from mail-ob0-f175.google.com ([209.85.214.175]:34714 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754048AbbHFG2f (ORCPT ); Thu, 6 Aug 2015 02:28:35 -0400 MIME-Version: 1.0 In-Reply-To: <1438839848-505-3-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1438839848-505-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1438839848-505-3-git-send-email-vivien.didelot@savoirfairelinux.com> From: Scott Feldman Date: Wed, 5 Aug 2015 23:28:15 -0700 Message-ID: Subject: Re: [PATCH net-next v2 2/7] net: switchdev: support static FDB addresses To: Vivien Didelot Cc: Netdev , "linux-kernel@vger.kernel.org" , kernel , "David S. Miller" , Guenter Roeck , Andrew Lunn , Florian Fainelli , Jiri Pirko Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1981 Lines: 50 On Wed, Aug 5, 2015 at 10:44 PM, Vivien Didelot wrote: > This patch adds a is_static boolean to the switchdev_obj_fdb structure, > in order to set the ndm_state to either NUD_NOARP or NUD_REACHABLE. > > Signed-off-by: Vivien Didelot > --- > include/net/switchdev.h | 1 + > net/switchdev/switchdev.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/net/switchdev.h b/include/net/switchdev.h > index e90e1a0..0e296b8 100644 > --- a/include/net/switchdev.h > +++ b/include/net/switchdev.h > @@ -72,6 +72,7 @@ struct switchdev_obj { > struct switchdev_obj_fdb { /* PORT_FDB */ > u8 addr[ETH_ALEN]; > u16 vid; > + bool is_static; What do you think about changing this to u16 ndm_state? That way, it can be used on input (fdb add) and output (fdb dump), and the driver can privately track the state, kind of like how the bridge keeps is_static, is_local, etc. > } fdb; > } u; > }; > diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c > index 9db87a3..e9d1cac 100644 > --- a/net/switchdev/switchdev.c > +++ b/net/switchdev/switchdev.c > @@ -811,7 +811,7 @@ static int switchdev_port_fdb_dump_cb(struct net_device *dev, > ndm->ndm_flags = NTF_SELF; > ndm->ndm_type = 0; > ndm->ndm_ifindex = dev->ifindex; > - ndm->ndm_state = NUD_REACHABLE; > + ndm->ndm_state = obj->u.fdb.is_static ? NUD_NOARP : NUD_REACHABLE; > > if (nla_put(dump->skb, NDA_LLADDR, ETH_ALEN, obj->u.fdb.addr)) > goto nla_put_failure; > -- > 2.4.6 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/