Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754391AbbHFHpu (ORCPT <rfc822;w@1wt.eu>);
	Thu, 6 Aug 2015 03:45:50 -0400
Received: from TYO201.gate.nec.co.jp ([210.143.35.51]:62650 "EHLO
	tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751008AbbHFHps (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 6 Aug 2015 03:45:48 -0400
From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: David Rientjes <rientjes@google.com>
CC: =?utf-8?B?SsO2cm4gRW5nZWw=?= <joern@purestorage.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] smaps: fill missing fields for vma(VM_HUGETLB)
Thread-Topic: [PATCH] smaps: fill missing fields for vma(VM_HUGETLB)
Thread-Index: AQHQznRSEg5CNM2w20WnYVDLM1ypkJ37kR6AgAIXiQCAAFsUgA==
Date: Thu, 6 Aug 2015 07:44:44 +0000
Message-ID: <20150806074443.GA7870@hori1.linux.bs1.fc.nec.co.jp>
References: <alpine.DEB.2.10.1507281509420.23577@chino.kir.corp.google.com>
 <20150728222654.GA28456@Sligo.logfs.org>
 <alpine.DEB.2.10.1507281622470.10368@chino.kir.corp.google.com>
 <20150729005332.GB17938@Sligo.logfs.org>
 <alpine.DEB.2.10.1507291205590.24373@chino.kir.corp.google.com>
 <55B95FDB.1000801@oracle.com>
 <20150804025530.GA13210@hori1.linux.bs1.fc.nec.co.jp>
 <20150804051339.GA24931@hori1.linux.bs1.fc.nec.co.jp>
 <20150804182158.GH14335@Sligo.logfs.org>
 <alpine.DEB.2.10.1508051917430.4843@chino.kir.corp.google.com>
In-Reply-To: <alpine.DEB.2.10.1508051917430.4843@chino.kir.corp.google.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.128.101.23]
Content-Type: text/plain; charset="utf-8"
Content-ID: <ABC6F904EE674643A446880AED11F08D@gisp.nec.co.jp>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t767jsaF013845
Content-Length: 739
Lines: 15

On Wed, Aug 05, 2015 at 07:18:44PM -0700, David Rientjes wrote:
...
> Hmm, wouldn't this be confusing since VmRSS in /proc/pid/status doesn't 
> match the rss shown in smaps, since hugetlb mappings aren't accounted in 
> get_mm_rss()?
> 
> Not sure this is a good idea, I think consistency amongst rss values would 
> be more important.

Right, so one option is making get_mm_rss() count hugetlb, but that could
make oom/memcg less efficient or broken as you stated in a previous email.
So another one is to add "VmHugetlbRSS:" field in /proc/pid/status?

Thanks,
Naoya Horiguchi????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?