Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754790AbbHFITJ (ORCPT ); Thu, 6 Aug 2015 04:19:09 -0400 Received: from nasmtp01.atmel.com ([192.199.1.245]:8894 "EHLO DVREDG01.corp.atmel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753522AbbHFITA (ORCPT ); Thu, 6 Aug 2015 04:19:00 -0400 From: "Yang, Wenyou" To: Guenter Roeck , "wim@iguana.be" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" CC: "sylvain.rochet@finsecur.com" , "Ferre, Nicolas" , "boris.brezillon@free-electrons.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v4 1/2] drivers: watchdog: add a driver to support SAMA5D4 watchdog timer Thread-Topic: [PATCH v4 1/2] drivers: watchdog: add a driver to support SAMA5D4 watchdog timer Thread-Index: AQHQ0AXL5xJ5MGk/bUakZRpateh0GZ3+FyaAgACHIYA= Date: Thu, 6 Aug 2015 08:18:52 +0000 Message-ID: References: <1438837170-4518-1-git-send-email-wenyou.yang@atmel.com> <1438837170-4518-2-git-send-email-wenyou.yang@atmel.com> <55C31547.2040207@roeck-us.net> In-Reply-To: <55C31547.2040207@roeck-us.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.168.5.13] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t768JDL8014034 Content-Length: 2627 Lines: 67 Hi Guenter, Thank you for your correct. > -----Original Message----- > From: Guenter Roeck [mailto:linux@roeck-us.net] > Sent: 2015??8??6?? 16:05 > To: Yang, Wenyou; wim@iguana.be; robh+dt@kernel.org; pawel.moll@arm.com; > mark.rutland@arm.com; ijc+devicetree@hellion.org.uk; galak@codeaurora.org > Cc: sylvain.rochet@finsecur.com; Ferre, Nicolas; boris.brezillon@free- > electrons.com; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > watchdog@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v4 1/2] drivers: watchdog: add a driver to support SAMA5D4 > watchdog timer > > On 08/05/2015 09:59 PM, Wenyou Yang wrote: > >>From SAMA5D4, the watchdog timer is upgrated with a new feature, > > which is describled as in the datasheet, "WDT_MR can be written until > > a LOCKMR command is issued in WDT_CR". > > That is to say, as long as the bootstrap and u-boot don't issue a > > LOCKMR command, WDT_MR can be written more than once in the driver. > > > > So the SAMA5D4 watchdog driver's implementation is different from the > > at91sam9260 watchdog driver implemented in file at91sam9_wdt.c. > > The user application open the device file to enable the watchdog timer > > hardware, and close to disable it, and set the watchdog timer timeout > > by seting WDV and WDD fields of WDT_MR register, and ping the watchdog > > by issuing WDRSTT command to WDT_CR register with hard-coded key. > > > > Signed-off-by: Wenyou Yang > > --- > [ ... ] > > + > > +/* minimum and maximum watchdog timeout, in seconds */ > > +#define MIN_WDT_TIMEOUT 1 > > +#define MAX_WDT_TIMEOUT 16 > > +#define WDT_DEFAULT_TIMEOUT MAX_WDT_TIMEOUT > > + > > +#define WDT_SEC2TICKS(s) ((s) ? (((s) << 8) - 1) : 0) > > + > > Why did you replace the spaces after #define with tabs ? > I understand this is done in the at91.h file, but that is bad enough, it doesn't add > any value, and I don't see a reason to do it here. Accepted, Using spaces, not tabs. > > > + > > + if ((wdt->config & AT91_WDT_WDFIEN) && irq) { > > + ret = devm_request_irq(&pdev->dev, irq, > sama5d4_wdt_irq_handler, > > + 0, pdev->name, pdev); > > I just realized - this interrupt is registered with flags set to 0, while in the at91sam > driver the flags are "IRQF_SHARED | IRQF_IRQPOLL | IRQF_NO_SUSPEND". Is > this different with the new SOC ? No, it is same. It is my carelessness. > > Thanks, > Guenter Best Regards, Wenyou Yang ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?