Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754901AbbHFIfj (ORCPT ); Thu, 6 Aug 2015 04:35:39 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:48279 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753854AbbHFIfg (ORCPT ); Thu, 6 Aug 2015 04:35:36 -0400 X-Listener-Flag: 11101 Message-ID: <1438850132.27884.17.camel@mtksdaap41> Subject: Re: [PATCH v6 5/9] clk: mediatek: Fix rate and dependency of MT8173 clocks From: James Liao To: Sascha Hauer CC: Matthias Brugger , Mike Turquette , Stephen Boyd , "Heiko Stubner" , , , , Daniel Kurtz , Ricky Liang , Rob Herring , , Sascha Hauer , Date: Thu, 6 Aug 2015 16:35:32 +0800 In-Reply-To: <20150805065341.GA18700@pengutronix.de> References: <1438676218-11310-1-git-send-email-jamesjj.liao@mediatek.com> <1438676218-11310-6-git-send-email-jamesjj.liao@mediatek.com> <20150805065341.GA18700@pengutronix.de> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1488 Lines: 35 Hi Sascha, On Wed, 2015-08-05 at 08:53 +0200, Sascha Hauer wrote: > On Tue, Aug 04, 2015 at 04:16:54PM +0800, James Liao wrote: > > -static const struct mtk_fixed_factor root_clk_alias[] __initconst = { > > - FACTOR(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk_null", 1, 1), > > - FACTOR(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk_null", 1, 1), > > - FACTOR(CLK_TOP_HDMITX_DIG_CTS, "hdmitx_dig_cts", "clk_null", 1, 1), > > +static const struct mtk_fixed_clk fixed_clks[] __initconst = { > > + FIXED_CLK(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk26m", 400 * MHZ), > > + FIXED_CLK(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk26m", 125 * MHZ), > > Hm, it seems you hide PLLs in fixed factor clock. Are you sure that > there is a PLL in the system generating 125MHz from 26MHz which is in no > way configurable? Or is this really some clock derived from the syspll > as the clock name suggests? According to the datasheet from our clock designer, usb_syspll_125m is the output clock of an analog macro which is named SSUSB_PHY, and its input clock is AD_CLK26M_CK. SSUSB_PHY is not the same as general PLLs such as MAINPLL. So I don't treat it as a configurable PLL but a fixed clock with the typical rate 125 MHz. Best regards, James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/