Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755163AbbHFJGx (ORCPT ); Thu, 6 Aug 2015 05:06:53 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:37905 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754620AbbHFJGu (ORCPT ); Thu, 6 Aug 2015 05:06:50 -0400 Subject: Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks] To: Chen Bough , Ulf Hansson References: <55B9EF02.7040404@suse.cz> <55BF36D6.4080504@suse.cz> <55C1F919.4080002@suse.cz> <55C227B4.3030102@suse.cz> Cc: "linux-mmc@vger.kernel.org" , Linux kernel mailing list From: Jiri Slaby X-Enigmail-Draft-Status: N1110 Message-ID: <55C323A5.6050303@suse.cz> Date: Thu, 6 Aug 2015 11:06:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 782 Lines: 21 On 08/06/2015, 09:42 AM, Chen Bough wrote: > I read your attached log and patch, yes, dma memory leak will happen when > more than one pre_request execute. The method of ++next->cookie is not good, > your patch seems good, but I still need some time to test the patch, because > you unmap the dma in sdhci_finish_data rather than the sdhci_post_req. Hi, yes, this is not correct. We can perhaps differentiate according to the COOKIE value. Should I fix it or are you going to prepare a patch based on my RFC? thanks, -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/