Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755535AbbHFLZy (ORCPT ); Thu, 6 Aug 2015 07:25:54 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33635 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754376AbbHFLZw (ORCPT ); Thu, 6 Aug 2015 07:25:52 -0400 From: Shraddha Barke To: Benjamin Romer , David Kershner , Greg Kroah-Hartman , Neil Horman , Tim Sell , sparmaintainer@unisys.com, linux-kernel@vger.kernel.org Cc: Shraddha Barke Subject: [PATCH v2] Staging: unisys: visornic: Use kcalloc instead of kzalloc. Date: Thu, 6 Aug 2015 16:55:41 +0530 Message-Id: <1438860341-15248-1-git-send-email-shraddha.6596@gmail.com> X-Mailer: git-send-email 2.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1314 Lines: 37 This patch converts kzalloc to kcalloc. The advantage of kcalloc is, that will take care of integer overflows which could result from the multiplication and it is also nicer to read. The change was made using Coccinelle. Signed-off-by: Shraddha Barke --- Changes in v2; -Make commit message clearer. drivers/staging/unisys/visornic/visornic_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c index 2a9b055..e4a7b9b5 100644 --- a/drivers/staging/unisys/visornic/visornic_main.c +++ b/drivers/staging/unisys/visornic/visornic_main.c @@ -1843,8 +1843,8 @@ static int visornic_probe(struct visor_device *dev) goto cleanup_netdev; } - devdata->rcvbuf = kzalloc(sizeof(struct sk_buff *) * - devdata->num_rcv_bufs, GFP_KERNEL); + devdata->rcvbuf = kcalloc(devdata->num_rcv_bufs, + sizeof(struct sk_buff *), GFP_KERNEL); if (!devdata->rcvbuf) { err = -ENOMEM; goto cleanup_rcvbuf; -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/