Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 17 Feb 2003 09:01:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 17 Feb 2003 09:01:11 -0500 Received: from fencepost.gnu.org ([199.232.76.164]:42143 "EHLO fencepost.gnu.org") by vger.kernel.org with ESMTP id ; Mon, 17 Feb 2003 08:59:45 -0500 Date: Mon, 17 Feb 2003 09:09:44 -0500 To: Christoph Hellwig , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Make sysctl vm subdir dependent on CONFIG_MMU Message-ID: <20030217140944.GA21202@gnu.org> References: <20030217105900.5E2683728@mcspd15.ucom.lsi.nec.co.jp> <20030217125504.A25066@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030217125504.A25066@infradead.org> User-Agent: Mutt/1.3.28i Blat: Foop From: Miles Bader Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 711 Lines: 18 On Mon, Feb 17, 2003 at 12:55:04PM +0000, Christoph Hellwig wrote: > These ifdefs are ugly - please move the whole table into a file that > isn't compiled when CONFIG_MMU isn't set (e.g. memory.c) and use > register_sysctl_table() Hmm, somehow I thought you were going to say that ... :-) Either way is OK with me, but note that I just followed the style already used in sysctl.c for CONFIG_NET. -Miles -- Saa, shall we dance? (from a dance-class advertisement) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/