Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755597AbbHFMBE (ORCPT ); Thu, 6 Aug 2015 08:01:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40546 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754578AbbHFMBB (ORCPT ); Thu, 6 Aug 2015 08:01:01 -0400 Subject: Re: [PATCH] kvm:arm:Fix error handling in the function vgic_v3_probe To: Marc Zyngier , nick , "christoffer.dall@linaro.org" References: <1438793303-30228-1-git-send-email-xerofoify@gmail.com> <55C240D9.5060900@redhat.com> <55C242C6.6060200@gmail.com> <55C31582.4000809@arm.com> Cc: "gleb@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Paolo Bonzini Message-ID: <55C34C77.7090303@redhat.com> Date: Thu, 6 Aug 2015 14:00:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55C31582.4000809@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 23 On 06/08/2015 10:06, Marc Zyngier wrote: > > If this structure of function pointers can handle function pointers with a return type of > > void I will be glad to do what you request otherwise this would require a major rewrite > > of kvm arm subsystem for a very simple bug fix. > > Just like Paolo said, the error you report should never happen, and > would be caught by a WARN_ON() the first time anyone boots the kernel. > Also, failing to register the device ops results in not being able to > instantiate a VGIC. No harm done. I really don't understand why you want > to rewrite the probe functions. I think he just misunderstood my suggestion. I didn't suggest making the probe functions return void. I suggested that kvm_register_device_ops return void. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/