Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755726AbbHFOWv (ORCPT ); Thu, 6 Aug 2015 10:22:51 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:9001 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753384AbbHFOWR (ORCPT ); Thu, 6 Aug 2015 10:22:17 -0400 X-IronPort-AV: E=Sophos;i="5.15,622,1432598400"; d="scan'208";a="292046222" Date: Thu, 6 Aug 2015 15:20:09 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Julien Grall CC: Stefano Stabellini , , "H. Peter Anvin" , Jiri Slaby , Boris Ostrovsky , Russell King , , Tomi Valkeinen , , Ingo Molnar , , , Jean-Christophe Plagniol-Villard , , "James E.J. Bottomley" , Thomas Gleixner , , Juergen Gross , Wei Liu , "Greg Kroah-Hartman" , Dmitry Torokhov , , David Vrabel , , , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies In-Reply-To: <55C34250.3040801@citrix.com> Message-ID: References: <1438711972-18752-1-git-send-email-julien.grall@citrix.com> <1438711972-18752-5-git-send-email-julien.grall@citrix.com> <55C33E4E.4050704@citrix.com> <55C34250.3040801@citrix.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 38 On Thu, 6 Aug 2015, Julien Grall wrote: > On 06/08/15 12:06, Stefano Stabellini wrote: > > On Thu, 6 Aug 2015, Julien Grall wrote: > >> Hi, > >> > >> > >> On 04/08/15 19:12, Julien Grall wrote: > >>> diff --git a/include/xen/page.h b/include/xen/page.h > >>> index c5ed20b..e7e1425 100644 > >>> --- a/include/xen/page.h > >>> +++ b/include/xen/page.h > >>> @@ -3,9 +3,9 @@ > >>> > >>> #include > >>> > >>> -static inline unsigned long page_to_mfn(struct page *page) > >>> +static inline unsigned long page_to_gfn(struct page *page) > >>> { > >>> - return pfn_to_mfn(page_to_pfn(page)); > >>> + return pfn_to_gfn(page_to_pfn(page)); > >>> } > >> > >> I've just noticed that there is a function gfn_to_page used for KVM. > >> > >> Maybe I should rename page_to_gfn to xen_page_to_gfn to avoid confusion > >> with KVM one? > > > > Yeah, prepending xen would help to avoid namespace pollution. > > Will do. May I keep your Reviewed-by for this mechanical change? Yes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/