Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755918AbbHFO1k (ORCPT ); Thu, 6 Aug 2015 10:27:40 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:55134 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754261AbbHFO1i (ORCPT ); Thu, 6 Aug 2015 10:27:38 -0400 X-IronPort-AV: E=Sophos;i="5.15,622,1432591200"; d="scan'208";a="172867245" Date: Thu, 6 Aug 2015 16:27:31 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Sergey Senozhatsky cc: Julia Lawall , Sergey Senozhatsky , David Rientjes , Andrew Morton , Minchan Kim , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in kmem_cache_destroy() In-Reply-To: <20150806142131.GB4292@swordfish> Message-ID: References: <1433851493-23685-1-git-send-email-sergey.senozhatsky@gmail.com> <1433851493-23685-2-git-send-email-sergey.senozhatsky@gmail.com> <20150617235205.GA3422@swordfish> <20150806142131.GB4292@swordfish> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1364 Lines: 42 On Thu, 6 Aug 2015, Sergey Senozhatsky wrote: > On (06/19/15 08:50), Julia Lawall wrote: > > On Thu, 18 Jun 2015, Sergey Senozhatsky wrote: > > > > > On (06/17/15 16:14), David Rientjes wrote: > > > [..] > > > > > > > > > > Signed-off-by: Sergey Senozhatsky > > > > > Reported-by: Andrew Morton > > > > > LKML-reference: https://lkml.org/lkml/2015/6/8/583 > > > > > > > > Acked-by: David Rientjes > > > > > > > > kmem_cache_destroy() isn't a fastpath, this is long overdue. Now where's > > > > the patch to remove the NULL checks from the callers? ;) > > > > > > > > > > Thanks. > > > > > > Yes, Julia Lawall (Cc'd) already has a patch set ready for submission. > > > > I'll refresh it and send it shortly. > > > > I'll re-up this thread. > > Julia, do you want to wait until these 3 patches will be merged to > Linus's tree (just to be on a safe side, so someone's tree (out of sync > with linux-next) will not go crazy)? I think it would be safer. Code may crash if the test is removed before the function can tolerate it. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/