Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755563AbbHFO3q (ORCPT ); Thu, 6 Aug 2015 10:29:46 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:41972 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753533AbbHFO3o (ORCPT ); Thu, 6 Aug 2015 10:29:44 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <02b9457648b5eb6e124acb44b934f7aa> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode To: Jingoo Han , "'Heiko Stuebner'" , "'Russell King'" , "'Fabio Estevam'" , "'Inki Dae'" References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <1438870041-23130-1-git-send-email-ykk@rock-chips.com> <000001d0d052$f44fa3a0$dceeeae0$@com> Cc: djkurtz@google.com, dianders@google.com, "'Takashi Iwai'" , "'Andrzej Hajda'" , "'Thierry Reding'" , "'Philipp Zabel'" , "'David Airlie'" , "'Gustavo Padovan'" , "'Seung-Woo Kim'" , "'Kyungmin Park'" , "'Krzysztof Kozlowski'" , "'Kukjin Kim'" , "'Ajay Kumar'" , "'Joonyoung Shim'" , "'Vincent Palatin'" , "'Mark Yao'" , "'Andy Yan'" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <55C36F49.6020207@rock-chips.com> Date: Thu, 6 Aug 2015 22:29:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <000001d0d052$f44fa3a0$dceeeae0$@com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2368 Lines: 70 Hi Jingoo, 在 2015/8/6 22:19, Jingoo Han 写道: > On Thursday, August 06, 2015 11:07 PM, Yakir Yang wrote: >> In order to move exynos dp code to bridge directory, >> we need to convert driver drm bridge mode first. As >> dp driver already have a ptn3460 bridge, so we need >> to move ptn bridge to the next bridge of dp bridge. >> >> Signed-off-by: Yakir Yang >> --- >> drivers/gpu/drm/exynos/exynos_dp_core.c | 196 ++++++++++++++++++++------------ >> drivers/gpu/drm/exynos/exynos_dp_core.h | 2 + >> 2 files changed, 126 insertions(+), 72 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c >> index a8097a4..aa99e23 100644 >> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c >> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c >> @@ -3,6 +3,7 @@ >> * >> * Copyright (C) 2012 Samsung Electronics Co., Ltd. >> * Author: Jingoo Han >> + * Yakir Yang > Please don't add this. > You just fixed some parts of this code. I don't find the reason > why you have to be added to author for this file. > If you want the title for an author, please send the patch > for a new IP, instead of modifying the exiting codes. Okay, thanks for your remind ;) >> [...] >> MODULE_AUTHOR("Jingoo Han "); >> +MODULE_AUTHOR("Yakir Yang "); > The same as above. Done >> MODULE_DESCRIPTION("Samsung SoC DP Driver"); >> MODULE_LICENSE("GPL v2"); >> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.h b/drivers/gpu/drm/exynos/exynos_dp_core.h >> index c321ad5..f2584b8 100644 >> --- a/drivers/gpu/drm/exynos/exynos_dp_core.h >> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.h >> @@ -3,6 +3,7 @@ >> * >> * Copyright (C) 2012 Samsung Electronics Co., Ltd. >> * Author: Jingoo Han >> + * Yakir Yang > The same as above. > Here, you just added 1 line. If we add someone to author > in this way, a lot of people should be added to author. Done - Yakir > Best regards, > Jingoo Han > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/